From: Andreas Schwab <schwab@suse.de>
To: Florian Weimer <fweimer@redhat.com>
Cc: Paul Eggert <eggert@cs.ucla.edu>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] malloc: Implement heap protector
Date: Tue, 08 Nov 2016 16:09:00 -0000 [thread overview]
Message-ID: <mvm1symdkdg.fsf@hawking.suse.de> (raw)
In-Reply-To: <296af8bd-17ab-439e-90d1-bfadf3684c7f@redhat.com> (Florian Weimer's message of "Tue, 8 Nov 2016 16:13:26 +0100")
On Nov 08 2016, Florian Weimer <fweimer@redhat.com> wrote:
>>> +#define set_foot(p, s) \
>>> + (((mchunkptr) ((char *) (p) + (s)))->mchunk_prev_size \
>>> + = HEAP_CRYPT_PREVSIZE (s))
>>
>> Last line is indented one space too much.
>
> I don't have firm opinion on this one. In general, operators on continued
> lines are indented by two spaces.
Continuned lines are not indented relative to the containing expression.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2016-11-08 16:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 13:17 Florian Weimer
2016-10-28 15:05 ` Carlos O'Donell
2016-10-28 17:56 ` Paul Eggert
2016-11-08 15:13 ` Florian Weimer
2016-11-08 16:09 ` Andreas Schwab [this message]
2016-11-10 15:39 ` Florian Weimer
2016-10-28 20:45 ` DJ Delorie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvm1symdkdg.fsf@hawking.suse.de \
--to=schwab@suse.de \
--cc=eggert@cs.ucla.edu \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).