* [committed] __glibc_unsafe_len: Fix comment
@ 2021-12-16 1:52 Siddhesh Poyarekar
2021-12-16 10:24 ` Adhemerval Zanella
0 siblings, 1 reply; 4+ messages in thread
From: Siddhesh Poyarekar @ 2021-12-16 1:52 UTC (permalink / raw)
To: libc-alpha
We know that the length is *unsafe*.
Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
---
misc/sys/cdefs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/misc/sys/cdefs.h b/misc/sys/cdefs.h
index ab57d4a065..a05b538579 100644
--- a/misc/sys/cdefs.h
+++ b/misc/sys/cdefs.h
@@ -169,7 +169,7 @@
__s, __osz)) \
&& __glibc_safe_len_cond ((__SIZE_TYPE__) (__l), __s, __osz))
-/* Conversely, we know at compile time that the length is safe if the
+/* Conversely, we know at compile time that the length is unsafe if the
__L * __S <= __OBJSZ condition can be folded to a constant and if it is
false. */
#define __glibc_unsafe_len(__l, __s, __osz) \
--
2.31.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [committed] __glibc_unsafe_len: Fix comment
2021-12-16 1:52 [committed] __glibc_unsafe_len: Fix comment Siddhesh Poyarekar
@ 2021-12-16 10:24 ` Adhemerval Zanella
2021-12-16 10:44 ` Siddhesh Poyarekar
0 siblings, 1 reply; 4+ messages in thread
From: Adhemerval Zanella @ 2021-12-16 10:24 UTC (permalink / raw)
To: libc-alpha, Siddhesh Poyarekar
On 15/12/2021 22:52, Siddhesh Poyarekar via Libc-alpha wrote:
> We know that the length is *unsafe*.
>
> Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
Seems obvious enough.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> misc/sys/cdefs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/misc/sys/cdefs.h b/misc/sys/cdefs.h
> index ab57d4a065..a05b538579 100644
> --- a/misc/sys/cdefs.h
> +++ b/misc/sys/cdefs.h
> @@ -169,7 +169,7 @@
> __s, __osz)) \
> && __glibc_safe_len_cond ((__SIZE_TYPE__) (__l), __s, __osz))
>
> -/* Conversely, we know at compile time that the length is safe if the
> +/* Conversely, we know at compile time that the length is unsafe if the
> __L * __S <= __OBJSZ condition can be folded to a constant and if it is
> false. */
> #define __glibc_unsafe_len(__l, __s, __osz) \
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [committed] __glibc_unsafe_len: Fix comment
2021-12-16 10:24 ` Adhemerval Zanella
@ 2021-12-16 10:44 ` Siddhesh Poyarekar
2021-12-16 11:21 ` Adhemerval Zanella
0 siblings, 1 reply; 4+ messages in thread
From: Siddhesh Poyarekar @ 2021-12-16 10:44 UTC (permalink / raw)
To: Adhemerval Zanella, libc-alpha
On 12/16/21 15:54, Adhemerval Zanella via Libc-alpha wrote:
>
>
> On 15/12/2021 22:52, Siddhesh Poyarekar via Libc-alpha wrote:
>> We know that the length is *unsafe*.
>>
>> Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
>
> Seems obvious enough.
>
> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Oh I already committed that one as obvious, could you please review this
one:
https://patchwork.sourceware.org/project/glibc/patch/20211216014731.3939905-1-siddhesh@sourceware.org/
Thanks,
Siddhesh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [committed] __glibc_unsafe_len: Fix comment
2021-12-16 10:44 ` Siddhesh Poyarekar
@ 2021-12-16 11:21 ` Adhemerval Zanella
0 siblings, 0 replies; 4+ messages in thread
From: Adhemerval Zanella @ 2021-12-16 11:21 UTC (permalink / raw)
To: Siddhesh Poyarekar, libc-alpha
On 16/12/2021 07:44, Siddhesh Poyarekar wrote:
> On 12/16/21 15:54, Adhemerval Zanella via Libc-alpha wrote:
>>
>>
>> On 15/12/2021 22:52, Siddhesh Poyarekar via Libc-alpha wrote:
>>> We know that the length is *unsafe*.
>>>
>>> Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
>>
>> Seems obvious enough.
>>
>> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
> Oh I already committed that one as obvious, could you please review this one:
Oops I did not see the 'committed' title.
>
> https://patchwork.sourceware.org/project/glibc/patch/20211216014731.3939905-1-siddhesh@sourceware.org/
>
Sure.
> Thanks,
> Siddhesh
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-16 11:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-16 1:52 [committed] __glibc_unsafe_len: Fix comment Siddhesh Poyarekar
2021-12-16 10:24 ` Adhemerval Zanella
2021-12-16 10:44 ` Siddhesh Poyarekar
2021-12-16 11:21 ` Adhemerval Zanella
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).