From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [RFC 2/2] Fold compat_symbol_unique functionality into compat_symbol
Date: Fri, 19 Mar 2021 17:26:52 -0300 [thread overview]
Message-ID: <ee714da8-9bb4-64dd-8379-ad914e51b294@linaro.org> (raw)
In-Reply-To: <8735wqj3ub.fsf@oldenburg.str.redhat.com>
On 19/03/2021 17:17, Florian Weimer wrote:
> * Adhemerval Zanella:
>
>> I am seeing this with binutils 2.33 on i686-linux-gnu:
>>
>> x86_64-glibc-linux-gnu-gcc -m32 -march=i686 malloc.c -c -std=gnu11 -fgnu89-inline -g -O2 -Wall -Wwrite-strings -Wundef -Werror -fmerge-all-constants -frounding-math -fno-stack-protector -Wstrict-prototypes -Wold-style-definition -fmath-errno -fPIC -Wa,-mtune=i686 -DMORECORE_CLEARS=2 -ftls-model=initial-exec -I../include -I/home/azanella/Projects/glibc/build/i686-linux-gnu/malloc -I/home/azanella/Projects/glibc/build/i686-linux-gnu -I../sysdeps/unix/sysv/linux/i386/i686 -I../sysdeps/i386/i686/nptl -I../sysdeps/unix/sysv/linux/i386 -I../sysdeps/unix/sysv/linux/x86/include -I../sysdeps/unix/sysv/linux/x86 -I../sysdeps/x86/nptl -I../sysdeps/i386/nptl -I../sysdeps/unix/sysv/linux/include -I../sysdeps/unix/sysv/linux -I../sysdeps/nptl -I../sysdeps/pthread -I../sysdeps/gnu -I../sysdeps/unix/inet -I../sysdeps/unix/sysv -I../sysdeps/unix/i386 -I../sysdeps/unix -I../sysdeps/posix -I../sysdeps/i386/i686/fpu/multiarch -I../sysdeps/i386/i686/fpu -I../sysdeps/i386/i686/multiarch -I../sysdeps/i386/i686 -I../sysdeps/i386/fpu -I../sysdeps/x86/fpu -I../sysdeps/i386 -I../sysdeps/x86/include -I../sysdeps/x86 -I../sysdeps/wordsize-32 -I../sysdeps/ieee754/float128 -I../sysdeps/ieee754/ldbl-96/include -I../sysdeps/ieee754/ldbl-96 -I../sysdeps/ieee754/dbl-64 -I../sysdeps/ieee754/flt-32 -I../sysdeps/ieee754 -I../sysdeps/generic -I.. -I../libio -I. -D_LIBC_REENTRANT -include /home/azanella/Projects/glibc/build/i686-linux-gnu/libc-modules.h -DMODULE_NAME=libc -include ../include/libc-symbols.h -DPIC -DSHARED -DUSE_TCACHE=1 -DTOP_NAMESPACE=glibc -o /home/azanella/Projects/glibc/build/i686-linux-gnu/malloc/malloc.os -MD -MP -MF /home/azanella/Projects/glibc/build/i686-linux-gnu/malloc/malloc.os.dt -MT /home/azanella/Projects/glibc/build/i686-linux-gnu/malloc/malloc.os
>> /tmp/ccrOfJvr.s: Assembler messages:
>> /tmp/ccrOfJvr.s: Error: `__SI__malloc_initialize_hook_0' can't be equated to common symbol `__malloc_initialize_hook'
>
> Ahh, the GCC version is actually relevant here. It needs __attribute__
> ((nocommon)). I will at it.
>
> Are there any other symbols with the same problem?
>
The __attribute__ ((nocommon)) on the malloc hook fixed the build issue.
next prev parent reply other threads:[~2021-03-19 20:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 20:06 [RFC 0/2] Transparent multi-version symbol support Florian Weimer
2021-03-18 20:07 ` [RFC 1/2] Change how the symbol_version_reference macro is defined Florian Weimer
2021-03-19 18:47 ` Adhemerval Zanella
2021-03-18 20:07 ` [RFC 2/2] Fold compat_symbol_unique functionality into compat_symbol Florian Weimer
2021-03-18 21:37 ` Joseph Myers
2021-03-19 18:59 ` Adhemerval Zanella
2021-03-19 19:13 ` Florian Weimer
2021-03-19 19:34 ` Adhemerval Zanella
2021-03-19 20:10 ` Adhemerval Zanella
2021-03-19 20:17 ` Florian Weimer
2021-03-19 20:26 ` Adhemerval Zanella [this message]
2021-03-19 20:29 ` Florian Weimer
2021-03-19 20:33 ` Adhemerval Zanella
2021-03-19 20:33 ` Adhemerval Zanella
2021-03-19 19:02 ` [RFC 0/2] Transparent multi-version symbol support Adhemerval Zanella
2021-03-19 19:14 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee714da8-9bb4-64dd-8379-ad914e51b294@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).