From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [RFC 2/2] Fold compat_symbol_unique functionality into compat_symbol
Date: Fri, 19 Mar 2021 17:33:11 -0300 [thread overview]
Message-ID: <9d735827-0c63-cc97-c2d1-32d25937abd6@linaro.org> (raw)
In-Reply-To: <87y2eihop2.fsf@oldenburg.str.redhat.com>
On 19/03/2021 17:29, Florian Weimer wrote:
> * Adhemerval Zanella:
>
>> The __attribute__ ((nocommon)) on the malloc hook fixed the build issue.
>
> I've fixed this locally, and also added to versioned_symbol:
>
> If LOCAL is a data symbol and does not have a non-zero initializer,
> it should be defined with __attribute__ ((nocommon)) for
> compatibility with GCC versions that default to -fcommon. */
>
> Should I posted a v3?
I don't think is a need, I will review the v2.
next prev parent reply other threads:[~2021-03-19 20:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 20:06 [RFC 0/2] Transparent multi-version symbol support Florian Weimer
2021-03-18 20:07 ` [RFC 1/2] Change how the symbol_version_reference macro is defined Florian Weimer
2021-03-19 18:47 ` Adhemerval Zanella
2021-03-18 20:07 ` [RFC 2/2] Fold compat_symbol_unique functionality into compat_symbol Florian Weimer
2021-03-18 21:37 ` Joseph Myers
2021-03-19 18:59 ` Adhemerval Zanella
2021-03-19 19:13 ` Florian Weimer
2021-03-19 19:34 ` Adhemerval Zanella
2021-03-19 20:10 ` Adhemerval Zanella
2021-03-19 20:17 ` Florian Weimer
2021-03-19 20:26 ` Adhemerval Zanella
2021-03-19 20:29 ` Florian Weimer
2021-03-19 20:33 ` Adhemerval Zanella [this message]
2021-03-19 20:33 ` Adhemerval Zanella
2021-03-19 19:02 ` [RFC 0/2] Transparent multi-version symbol support Adhemerval Zanella
2021-03-19 19:14 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d735827-0c63-cc97-c2d1-32d25937abd6@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).