Re: [PATCH 02/18] Use LFS and 64 bit time for installed programs

[Adhemerval Zanella <adhemerval.zanella@linaro.org>]

On 17/06/2021 09:19, Andreas Schwab wrote:
> On Jun 17 2021, Adhemerval Zanella via Libc-alpha wrote:
> 
>> diff --git a/Makeconfig b/Makeconfig
>> index 6482a43025..de30ba3fa6 100644
>> --- a/Makeconfig
>> +++ b/Makeconfig
>> @@ -851,6 +851,10 @@ endif
>>  # -fno-math-errno.
>>  +extra-math-flags = $(if $(filter libm,$(in-module)),-fno-math-errno,-fmath-errno)
>>  
>> +# Use 64 bit time_t support for installed programs
>> ++extra-time-flags = $(if $(filter nonlib nscd lddlibc4 ldconfig locale_programs iconvprogs,\
> 
> I'd suggest to put the list of module names in a variable, to make it
> easier to shorten the line.

I will add it.

> 
>> diff --git a/Makerules b/Makerules
>> index 12f1a5cb50..770a573134 100644
>> --- a/Makerules
>> +++ b/Makerules
>> @@ -1313,14 +1313,22 @@ lib := testsuite
>>  include $(patsubst %,$(..)libof-iterator.mk,$(cpp-srcs-left))
>>  endif
>>  
>> -all-nonlib := $(strip $(tests-internal) $(test-internal-extras) \
>> -		      $(others) $(others-extras))
>> +all-nonlib := $(strip $(others) $(others-extras))
>>  ifneq (,$(all-nonlib))
>>  cpp-srcs-left = $(all-nonlib)
>>  lib := nonlib
>>  include $(patsubst %,$(..)libof-iterator.mk,$(cpp-srcs-left))
>>  endif
>>  
>> +# All internal tests use testsuite-internal module since for 64 bit time
>> +# support is set as default for MODULE_NAME=nonlib (which include some
>> +# installed programs.
> 
> Missing close paren.

Ack.

> 
>> diff --git a/locale/localeinfo.h b/locale/localeinfo.h
>> index b3d4da0185..9e53681829 100644
>> --- a/locale/localeinfo.h
>> +++ b/locale/localeinfo.h
>> @@ -50,7 +50,7 @@ struct __locale_data
>>  {
>>    const char *name;
>>    const char *filedata;		/* Region mapping the file data.  */
>> -  off_t filesize;		/* Size of the file (and the region).  */
>> +  __off_t filesize;		/* Size of the file (and the region).  */
> 
> Why is that needed?

It is a leftover from development, I will remove it.