public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH] Remove cached PID/TID in clone
Date: Thu, 24 Nov 2016 21:24:00 -0000	[thread overview]
Message-ID: <f487dc5a-3c3b-0955-a5e6-15825ea58766@linaro.org> (raw)
In-Reply-To: <6d415988-fb13-5f58-70fc-8b7d3d5ccfde@redhat.com>



On 15/11/2016 12:29, Florian Weimer wrote:
> On 11/15/2016 03:26 PM, Adhemerval Zanella wrote:
>> On 09/11/2016 10:18, Florian Weimer wrote:
>>>
>>> I really think we should document the clone system call wrapper and spell out these requirements, but that's a separate matter.
>>>
>>
>> Right, I think we can update documentation after patch is upstream.
> 
> Agreed.
> 
>> I also did a full check on aarch64, powerpc64le, and armhf.  I also did
>> some basic tests (basically the posix and nptl one involving clone/fork)
>> on a simulated sparc{64} and mips{64} machine to check if I missed
>> something in clone/vfork assembly changes.
> 
> I'm happy with the patch as-is.  I'd suggest to wait another week to see if the architecture maintainers have further comments and if not, check it in.

I has been about a week and no architecture maintainer chimed in. I
will commit it shortly.

As before, I rebased and I ran a full make check on x86_64, x32, i686,
armhf, aarch64, and powerpc64le.  I also checked some basic tests on 
sparc{32,64} and mips{32,64} on a simulated system.

So it would require further testing on alpha, hppa, ia64, m68k, nios2,
s390, sh, and tile (I excluded microblaze because it is already
implementing the patch semantic regarding clone/vfork).

  reply	other threads:[~2016-11-24 21:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-13 19:45 Adhemerval Zanella
2016-10-26 17:59 ` Adhemerval Zanella
2016-11-07 17:21 ` Florian Weimer
2016-11-08 19:58   ` Adhemerval Zanella
2016-11-08 20:11     ` Florian Weimer
2016-11-08 20:37       ` Adhemerval Zanella
2016-11-08 20:44         ` Florian Weimer
2016-11-09 12:18     ` Florian Weimer
2016-11-15 14:27       ` Adhemerval Zanella
2016-11-15 14:30         ` Florian Weimer
2016-11-24 21:24           ` Adhemerval Zanella [this message]
2016-11-25 10:50             ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f487dc5a-3c3b-0955-a5e6-15825ea58766@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).