From: Carlos O'Donell <carlos@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>, libc-alpha@sourceware.org
Subject: Re: Ignore MAP_VARIABLE in tst-mman-consts.py
Date: Wed, 22 Feb 2023 16:33:42 -0500 [thread overview]
Message-ID: <f4fe3ab8-65d2-321a-6764-c631c210fc35@redhat.com> (raw)
In-Reply-To: <8b3784bd-fdfb-bc98-9b9b-49e1c11482b@codesourcery.com>
On 2/22/23 12:56, Joseph Myers wrote:
> Linux 6.2 removed the hppa compatibility MAP_VARIABLE define. That
> means that, whether or not we remove it in glibc, it needs to be
> ignored in tst-mman-consts.py (since this macro comparison
> infrastructure expects that new kernel header versions only add new
> macros, not remove old ones).
>
> Tested with build-many-glibcs.py for hppa-linux-gnu (Linux 6.2
> headers).
Confirmed that with 71bdea6f798b425bc0003780b13e3fdecb16a010 the MAP_VARIABLE
define to 0 is removed.
LGTM.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> diff --git a/sysdeps/unix/sysv/linux/tst-mman-consts.py b/sysdeps/unix/sysv/linux/tst-mman-consts.py
> index 0bba893064..92b78a877c 100644
> --- a/sysdeps/unix/sysv/linux/tst-mman-consts.py
> +++ b/sysdeps/unix/sysv/linux/tst-mman-consts.py
> @@ -47,9 +47,12 @@ def main():
> # MAP_ANON alias for MAP_ANONYMOUS. MAP_RENAME, MAP_AUTOGROW,
> # MAP_LOCAL and MAP_AUTORSRV are in the kernel header for
> # MIPS, marked as "not used by linux"; SPARC has MAP_INHERIT
> - # in the kernel header, but does not use it.
> + # in the kernel header, but does not use it. The kernel
> + # header for HPPA removed a define of MAP_VARIABLE to 0 in
> + # Linux 6.2.
> 'MAP_HUGE_[0-9].*|MAP_UNINITIALIZED|MAP_FAILED|MAP_ANON'
> - '|MAP_RENAME|MAP_AUTOGROW|MAP_LOCAL|MAP_AUTORSRV|MAP_INHERIT',
> + '|MAP_RENAME|MAP_AUTOGROW|MAP_LOCAL|MAP_AUTORSRV|MAP_INHERIT'
> + '|MAP_VARIABLE',
> linux_version_glibc > linux_version_headers,
> linux_version_headers > linux_version_glibc))
>
>
--
Cheers,
Carlos.
prev parent reply other threads:[~2023-02-22 21:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 17:56 Joseph Myers
2023-02-22 21:33 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4fe3ab8-65d2-321a-6764-c631c210fc35@redhat.com \
--to=carlos@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).