public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH v2] Added International_Standard_Book_Number (ISBN) for various Locales
       [not found] <CGME20190722045940epcas5p17b46b1969d4c3c3b404fd807befde8ca@epcas5p1.samsung.com>
@ 2019-07-22  5:18 ` Akhilesh Kumar
  2019-07-22 19:41   ` Rafal Luzynski
  0 siblings, 1 reply; 3+ messages in thread
From: Akhilesh Kumar @ 2019-07-22  5:18 UTC (permalink / raw)
  To: digitalfreak, libc-alpha; +Cc: Akhilesh Kumar

We foud missing ISBN code for various locale. Currently we added ISBN code for
"Ethiopia” and "Eritrea". Later we will update ISBN code for others too.

Link:
[1] https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups

        [BZ #24817]
        * locales/aa_ER  (country_isbn): Added country_isbn.
        * locales/aa_ET  (country_isbn): Likewise.
        * locales/am_ET  (country_isbn): Likewise.
        * locales/byn_ER (country_isbn): Likewise.
        * locales/gez_ER (country_isbn): Likewise.
        * locales/gez_ET (country_isbn): Likewise.
        * locales/om_ET  (country_isbn): Likewise.
        * locales/sid_ET (country_isbn): Likewise.
        * locales/so_ET  (country_isbn): Likewise.
        * locales/ti_ER  (country_isbn): Likewise.
        * locales/ti_ET  (country_isbn): Likewise.
        * locales/tig_ER (country_isbn): Likewise.
        * locales/wal_ET (country_isbn): Likewise.
---
 localedata/locales/aa_ER  | 3 ++-
 localedata/locales/aa_ET  | 3 ++-
 localedata/locales/am_ET  | 3 ++-
 localedata/locales/byn_ER | 3 ++-
 localedata/locales/gez_ER | 3 ++-
 localedata/locales/gez_ET | 3 ++-
 localedata/locales/om_ET  | 3 ++-
 localedata/locales/sid_ET | 3 ++-
 localedata/locales/so_ET  | 3 ++-
 localedata/locales/ti_ER  | 3 ++-
 localedata/locales/ti_ET  | 3 ++-
 localedata/locales/tig_ER | 3 ++-
 localedata/locales/wal_ET | 3 ++-
 13 files changed, 26 insertions(+), 13 deletions(-)

diff --git a/localedata/locales/aa_ER b/localedata/locales/aa_ER
index 2d23b0f..ae744bc 100644
--- a/localedata/locales/aa_ER
+++ b/localedata/locales/aa_ER
@@ -112,7 +112,8 @@ country_ab2   "ER"
 country_ab3   "ERI"
 country_num   232
 country_car   "ER"
-% country_isbn  unknown, Need ISO 2108
+#https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
+country_isbn  99948
 lang_name     "Qafar"
 lang_ab       "aa"
 lang_term     "aar"
diff --git a/localedata/locales/aa_ET b/localedata/locales/aa_ET
index 1bc7c4a..816da8b 100644
--- a/localedata/locales/aa_ET
+++ b/localedata/locales/aa_ET
@@ -112,7 +112,8 @@ country_ab2   "ET"
 country_ab3   "ETH"
 country_num   231   % 210 found in at least one ISO 3166 doc
 country_car   "ETH"
-% country_isbn  unknown, Need ISO 2108
+#https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
+country_isbn  99944
 lang_name     "Qafar"
 lang_ab       "aa"
 lang_term     "aar"
diff --git a/localedata/locales/am_ET b/localedata/locales/am_ET
index 7846d62..365465d 100644
--- a/localedata/locales/am_ET
+++ b/localedata/locales/am_ET
@@ -947,7 +947,8 @@ country_ab3   "ETH"
 country_num   231   % 210 found in at least one ISO 3166 doc
 % ETH
 country_car   "ETH"
-% country_isbn  unknown, Need ISO 2108
+#https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
+country_isbn  99944
 lang_name     "<U12A0><U121B><U122D><U129B>"
 lang_ab      "am"
 lang_term    "amh"
diff --git a/localedata/locales/byn_ER b/localedata/locales/byn_ER
index 608378d..eea16f2 100644
--- a/localedata/locales/byn_ER
+++ b/localedata/locales/byn_ER
@@ -123,7 +123,8 @@ country_ab2   "ER"
 country_ab3   "ERI"
 country_num   232
 country_car  "ER"
-% country_isbn  unknown, Need ISO 2108
+#https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
+country_isbn  99948
 lang_name     "<U1265><U120A><U1295>"
 lang_ab       ""
 lang_term     "byn"
diff --git a/localedata/locales/gez_ER b/localedata/locales/gez_ER
index 261f9da..886ccc7 100644
--- a/localedata/locales/gez_ER
+++ b/localedata/locales/gez_ER
@@ -110,7 +110,8 @@ country_ab2   "ER"
 country_ab3   "ERI"
 country_num   232
 country_car   "ER"
-% country_isbn  unknown, Need ISO 2108
+#https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
+country_isbn  99948
 lang_name     "<U130D><U12D5><U12DD>"
 lang_term     "gez"
 %
diff --git a/localedata/locales/gez_ET b/localedata/locales/gez_ET
index bc8e0d3..f74b2f8 100644
--- a/localedata/locales/gez_ET
+++ b/localedata/locales/gez_ET
@@ -110,7 +110,8 @@ country_ab2   "ET"
 country_ab3   "ETH"
 country_num   231   % 210 found in at least one ISO 3166 doc
 country_car    "ETH"
-% country_isbn  unknown, Need ISO 2108
+#https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
+country_isbn  99944
 lang_name     "<U130D><U12D5><U12DD>"
 lang_term     "gez"
 %
diff --git a/localedata/locales/om_ET b/localedata/locales/om_ET
index 881b43f..efc12aa 100644
--- a/localedata/locales/om_ET
+++ b/localedata/locales/om_ET
@@ -145,7 +145,8 @@ country_ab2   "ET"
 country_ab3   "ETH"
 country_num   231   % 210 found in at least one ISO 3166 doc
 country_car    "ETH"
-% country_isbn  unknown, Need ISO 2108
+#https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
+country_isbn  99944
 lang_name     "Oromoo"
 lang_ab       "om"
 lang_term     "orm"
diff --git a/localedata/locales/sid_ET b/localedata/locales/sid_ET
index fd56445..2f38a95 100644
--- a/localedata/locales/sid_ET
+++ b/localedata/locales/sid_ET
@@ -113,7 +113,8 @@ country_ab2   "ET"
 country_ab3   "ETH"
 country_num   231   % 210 found in at least one ISO 3166 doc
 country_car   "ETH"
-% country_isbn  unknown, Need ISO 2108
+#https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
+country_isbn  99944 
 lang_name     "Sidaamu Afo"
 lang_term     "sid"
 lang_lib      "sid"
diff --git a/localedata/locales/so_ET b/localedata/locales/so_ET
index 2f8fe42..7fdcaa6 100644
--- a/localedata/locales/so_ET
+++ b/localedata/locales/so_ET
@@ -123,7 +123,8 @@ country_ab2   "ET"
 country_ab3   "ETH"
 country_num   231   % 210 found in at least one ISO 3166 doc
 country_car    "ETH"
-% country_isbn  unknown, Need ISO 2108
+#https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
+country_isbn  99944 
 lang_name     "Soomaali"
 lang_ab       "so"
 lang_term     "som"
diff --git a/localedata/locales/ti_ER b/localedata/locales/ti_ER
index 890bbb6..742adb3 100644
--- a/localedata/locales/ti_ER
+++ b/localedata/locales/ti_ER
@@ -143,7 +143,8 @@ country_ab2   "ER"
 country_ab3   "ERI"
 country_num   232
 country_car  "ER"
-% country_isbn  unknown, Need ISO 2108
+#https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
+country_isbn  99948
 lang_name     "<U1275><U130D><U122D><U129B>"
 lang_ab       "ti"
 lang_term     "tir"
diff --git a/localedata/locales/ti_ET b/localedata/locales/ti_ET
index e7c8ec3..fae57a4 100644
--- a/localedata/locales/ti_ET
+++ b/localedata/locales/ti_ET
@@ -946,7 +946,8 @@ country_ab2   "ET"
 country_ab3   "ETH"
 country_num   231   % 210 found in at least one ISO 3166 doc
 country_car    "ETH"
-% country_isbn  unknown, Need ISO 2108
+#https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
+country_isbn  99944
 lang_name     "<U1275><U130D><U122D><U129B>"
 lang_ab       "ti"
 lang_term     "tir"
diff --git a/localedata/locales/tig_ER b/localedata/locales/tig_ER
index 403a919..36386cc 100644
--- a/localedata/locales/tig_ER
+++ b/localedata/locales/tig_ER
@@ -123,7 +123,8 @@ country_ab2   "ER"
 country_ab3   "ERI"
 country_num   232
 country_car  "ER"
-% country_isbn  unknown, Need ISO 2108
+#https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
+country_isbn  99948
 lang_name     "<U1275><U130D><U1228>"
 lang_ab       ""
 lang_term     "tig"
diff --git a/localedata/locales/wal_ET b/localedata/locales/wal_ET
index 65b8e5f..8eca19a 100644
--- a/localedata/locales/wal_ET
+++ b/localedata/locales/wal_ET
@@ -110,7 +110,8 @@ country_ab2   "ET"
 country_ab3   "ETH"
 country_num   231   % 210 found in at least one ISO 3166 doc
 country_car    "ETH"
-% country_isbn  unknown, Need ISO 2108
+#https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
+country_isbn  99944
 lang_name     "<U12C8><U120B><U12ED><U1273><U1271>"
 lang_term     "wal"
 lang_lib      "wal"
-- 
1.9.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] Added International_Standard_Book_Number (ISBN) for various Locales
  2019-07-22  5:18 ` [PATCH v2] Added International_Standard_Book_Number (ISBN) for various Locales Akhilesh Kumar
@ 2019-07-22 19:41   ` Rafal Luzynski
  2019-07-23  4:39     ` Carlos O'Donell
  0 siblings, 1 reply; 3+ messages in thread
From: Rafal Luzynski @ 2019-07-22 19:41 UTC (permalink / raw)
  To: Akhilesh Kumar, libc-alpha; +Cc: Carlos O'Donell

22.07.2019 06:59 Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
> 
> We foud missing ISBN code for various locale. Currently we added ISBN code
> for
> "Ethiopia” and "Eritrea". Later we will update ISBN code for others too.
> 
> Link:
> [1] https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
> 
>         [BZ #24817]
>         * locales/aa_ER  (country_isbn): Added country_isbn.
>         * locales/aa_ET  (country_isbn): Likewise.
>         * locales/am_ET  (country_isbn): Likewise.
>         * locales/byn_ER (country_isbn): Likewise.
>         * locales/gez_ER (country_isbn): Likewise.
>         * locales/gez_ET (country_isbn): Likewise.
>         * locales/om_ET  (country_isbn): Likewise.
>         * locales/sid_ET (country_isbn): Likewise.
>         * locales/so_ET  (country_isbn): Likewise.
>         * locales/ti_ER  (country_isbn): Likewise.
>         * locales/ti_ET  (country_isbn): Likewise.
>         * locales/tig_ER (country_isbn): Likewise.
>         * locales/wal_ET (country_isbn): Likewise.
> ---
>  localedata/locales/aa_ER  | 3 ++-
>  localedata/locales/aa_ET  | 3 ++-
>  localedata/locales/am_ET  | 3 ++-
>  localedata/locales/byn_ER | 3 ++-
>  localedata/locales/gez_ER | 3 ++-
>  localedata/locales/gez_ET | 3 ++-
>  localedata/locales/om_ET  | 3 ++-
>  localedata/locales/sid_ET | 3 ++-
>  localedata/locales/so_ET  | 3 ++-
>  localedata/locales/ti_ER  | 3 ++-
>  localedata/locales/ti_ET  | 3 ++-
>  localedata/locales/tig_ER | 3 ++-
>  localedata/locales/wal_ET | 3 ++-
>  13 files changed, 26 insertions(+), 13 deletions(-)
> [...]

Thank you for this contribution, Akhilesh.  There are several new
issues in your patch.  But before I discuss them the major question is:

Carlos, do we want to fix this issue now as we are in the freeze period,
10 days before the next release?

Regards,

Rafal

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] Added International_Standard_Book_Number (ISBN) for various Locales
  2019-07-22 19:41   ` Rafal Luzynski
@ 2019-07-23  4:39     ` Carlos O'Donell
  0 siblings, 0 replies; 3+ messages in thread
From: Carlos O'Donell @ 2019-07-23  4:39 UTC (permalink / raw)
  To: Rafal Luzynski, Akhilesh Kumar, libc-alpha

On 7/22/19 3:39 PM, Rafal Luzynski wrote:
> 22.07.2019 06:59 Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
>>
>> We foud missing ISBN code for various locale. Currently we added ISBN code
>> for
>> "Ethiopia” and "Eritrea". Later we will update ISBN code for others too.
>>
>> Link:
>> [1] https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
>>
>>          [BZ #24817]
>>          * locales/aa_ER  (country_isbn): Added country_isbn.
>>          * locales/aa_ET  (country_isbn): Likewise.
>>          * locales/am_ET  (country_isbn): Likewise.
>>          * locales/byn_ER (country_isbn): Likewise.
>>          * locales/gez_ER (country_isbn): Likewise.
>>          * locales/gez_ET (country_isbn): Likewise.
>>          * locales/om_ET  (country_isbn): Likewise.
>>          * locales/sid_ET (country_isbn): Likewise.
>>          * locales/so_ET  (country_isbn): Likewise.
>>          * locales/ti_ER  (country_isbn): Likewise.
>>          * locales/ti_ET  (country_isbn): Likewise.
>>          * locales/tig_ER (country_isbn): Likewise.
>>          * locales/wal_ET (country_isbn): Likewise.
>> ---
>>   localedata/locales/aa_ER  | 3 ++-
>>   localedata/locales/aa_ET  | 3 ++-
>>   localedata/locales/am_ET  | 3 ++-
>>   localedata/locales/byn_ER | 3 ++-
>>   localedata/locales/gez_ER | 3 ++-
>>   localedata/locales/gez_ET | 3 ++-
>>   localedata/locales/om_ET  | 3 ++-
>>   localedata/locales/sid_ET | 3 ++-
>>   localedata/locales/so_ET  | 3 ++-
>>   localedata/locales/ti_ER  | 3 ++-
>>   localedata/locales/ti_ET  | 3 ++-
>>   localedata/locales/tig_ER | 3 ++-
>>   localedata/locales/wal_ET | 3 ++-
>>   13 files changed, 26 insertions(+), 13 deletions(-)
>> [...]
> 
> Thank you for this contribution, Akhilesh.  There are several new
> issues in your patch.  But before I discuss them the major question is:
> 
> Carlos, do we want to fix this issue now as we are in the freeze period,
> 10 days before the next release?

These are new features. I'd like these to wait.

-- 
Cheers,
Carlos.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-07-23  4:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20190722045940epcas5p17b46b1969d4c3c3b404fd807befde8ca@epcas5p1.samsung.com>
2019-07-22  5:18 ` [PATCH v2] Added International_Standard_Book_Number (ISBN) for various Locales Akhilesh Kumar
2019-07-22 19:41   ` Rafal Luzynski
2019-07-23  4:39     ` Carlos O'Donell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).