From: Carlos O'Donell <carlos@redhat.com>
To: Arjun Shankar <arjun.is@lostca.se>,
Andreas Schwab <schwab@linux-m68k.org>
Cc: libc-alpha@sourceware.org,
"Gabriel F. T. Gomes" <gabriel@inconstante.net.br>
Subject: Re: [PATCH] Set locale related environment variables in debugglibc.sh
Date: Thu, 24 Sep 2020 23:18:48 -0400 [thread overview]
Message-ID: <fae91e6e-f363-d047-03e3-fcbd01f8a086@redhat.com> (raw)
In-Reply-To: <20200924125555.GA35013@aloka.lostca.se>
On 9/24/20 8:55 AM, Arjun Shankar wrote:
> On Thu, Sep 24, 2020 at 09:51:11AM +0200, Andreas Schwab wrote:
>
>>> +# Container tests needing locale data should install them in-container.
>>> +# Other tests/binaries need to use locale data from the build tree.
>>> +if [ "$$CONTAINER" == false ]
>>
>> `==' is non-POSIX.
>
> Thanks, Andreas. I'll replace with `='.
The whole of debugglibc.sh is a bash script and as such may use bash
constructs, and indeed has other instances of '=='.
However, there is value in simplifying this to make it POSIX shell
compatible.
--
Cheers,
Carlos.
prev parent reply other threads:[~2020-09-25 3:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 16:06 Arjun Shankar
2020-09-24 1:54 ` Carlos O'Donell
2020-09-24 7:51 ` Andreas Schwab
2020-09-24 12:55 ` Arjun Shankar
2020-09-25 3:18 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fae91e6e-f363-d047-03e3-fcbd01f8a086@redhat.com \
--to=carlos@redhat.com \
--cc=arjun.is@lostca.se \
--cc=gabriel@inconstante.net.br \
--cc=libc-alpha@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).