From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: "Kacper Piwiński" <vfjpl1@gmail.com>,
"Carlos O'Donell" <carlos@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] linux: fix ntp_gettime abi break
Date: Fri, 3 Mar 2023 10:03:38 -0300 [thread overview]
Message-ID: <fc71b534-95ac-049a-fe28-83e5e880b90e@linaro.org> (raw)
In-Reply-To: <CAKVti-Bfsv5yVb4YHZOsaZMbQoNqzWSAZYFd_ESmSnyQVgO-VA@mail.gmail.com>
On 03/03/23 05:47, Kacper Piwiński via Libc-alpha wrote:
> czw., 2 mar 2023 o 18:47 Carlos O'Donell <carlos@redhat.com> napisał(a):
>>
>> On 2/20/23 23:04, Kacper Piwiński via Libc-alpha wrote:
>>> Between versions v2.11 and v2.12 struct ntptimeval got new fields.
>>> That wasn't a problem because new function ntp_gettimex was created
>>> (and made default) to support new struct. Old ntp_gettime was not
>>> using new fields so it was safe to call with old struct
>>> definition. Then between versions v2.31 and v2.32 when working on
>>> y2038 bugs, ntp_gettime start setting new fields.
>>>
>>> Sets fields manually to maintain compatibility with v2.11 struct definition.
>>
>> The patch fails to apply.
>>
>> This fails pre-commit CI:
>> https://patchwork.sourceware.org/project/glibc/patch/CAKVti-BRav=mmfcQBEz_qpezmKfR_fFW9uihJb+QXiJazugTmA@mail.gmail.com/
>>
>> Please have a look at:
>> https://sourceware.org/glibc/wiki/Contribution%20checklist
>>
>> Did you generate the patch with `git format-patch`?
>>
>
> Hi, yes I did but I didn't copy the whole thing. Anyway this patch is
> not correct. I attatched new patch here
> https://sourceware.org/bugzilla/show_bug.cgi?id=30156
Could you please resend as v2? Patch submission and discussion are done through
the maillist.
PS: maybe we should be more clear on wiki that patches are done discussed on
bugzilla.
next prev parent reply other threads:[~2023-03-03 13:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 4:04 Kacper Piwiński
2023-02-21 11:24 ` Andreas Schwab
2023-02-24 15:15 ` Kacper Piwiński
2023-03-02 17:47 ` Carlos O'Donell
2023-03-03 8:47 ` Kacper Piwiński
2023-03-03 13:03 ` Adhemerval Zanella Netto [this message]
2023-03-03 16:43 ` Kacper Piwiński
2023-03-07 14:11 ` Adhemerval Zanella Netto
2023-03-08 8:58 Kacper Piwiński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc71b534-95ac-049a-fe28-83e5e880b90e@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=vfjpl1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).