public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>,
	Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Cc: Siddhesh Poyarekar <siddhesh@sourceware.org>
Subject: Re: [PATCH v6] posix: Add terminal control setting support for posix_spawn
Date: Thu, 13 Jan 2022 14:21:51 -0300	[thread overview]
Message-ID: <fdddaedb-6592-83c7-88d9-ff26197719bf@linaro.org> (raw)
In-Reply-To: <87v8ynisp4.fsf@oldenburg.str.redhat.com>



On 13/01/2022 12:03, Florian Weimer wrote:
> * Adhemerval Zanella via Libc-alpha:
> 
>> diff --git a/include/unistd.h b/include/unistd.h
>> index 2bcdd494e1..6e71d80015 100644
>> --- a/include/unistd.h
>> +++ b/include/unistd.h
>> @@ -183,6 +183,10 @@ extern int __truncate (const char *path, __off_t __length);
>>  extern void *__sbrk (intptr_t __delta);
>>  libc_hidden_proto (__sbrk)
>>  
>> +extern int __tcsetpgrp (int fd, __pid_t pgrp);
>> +libc_hidden_proto (__tcsetpgrp)
>> +extern pid_t __getpgrp (void);
>> +libc_hidden_proto (__getpgrp);
> 
> Is __getpgrp used anywhere?
> 
> The patch seems to use __getpgid instead.

This is a leftover from previous iterations, I will remove it.

> 
>> +  /* Trying to set the controlling terminal after a setsid() incurs in a ENOTTY
> 
> No () after function name?

Ack.

> 
> Thanks,
> Florian
> 

  reply	other threads:[~2022-01-13 17:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-13 14:39 Adhemerval Zanella
2022-01-13 15:03 ` Florian Weimer
2022-01-13 17:21   ` Adhemerval Zanella [this message]
2022-01-24 17:25 ` Carlos O'Donell
2022-01-24 17:48   ` Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fdddaedb-6592-83c7-88d9-ff26197719bf@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=siddhesh@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).