public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Subject: Re: [COMMITTED] support: Fix xclone build failures on ia64 and hppa
Date: Fri, 25 Jun 2021 09:37:51 -0300	[thread overview]
Message-ID: <fe796f6a-962c-0e7e-eb00-680af0dad537@linaro.org> (raw)
In-Reply-To: <87czsaic6v.fsf@oldenburg.str.redhat.com>



On 25/06/2021 05:24, Florian Weimer via Libc-alpha wrote:
> ---
>  support/xclone.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/support/xclone.c b/support/xclone.c
> index 924d2b8754..243eee8b23 100644
> --- a/support/xclone.c
> +++ b/support/xclone.c
> @@ -30,15 +30,14 @@ xclone (int (*fn) (void *arg), void *arg, void *stack, size_t stack_size,
>  # ifdef __ia64__
>    extern int __clone2 (int (*fn) (void *arg), void *stack, size_t stack_size,
>  		       int flags, void *arg, ...);
> -  r = __clone2 (f, stack, stack_size, flags, arg, /* ptid */ NULL,
> -		/* tls */ NULL, /* ctid  */ ctid);
> +  r = __clone2 (fn, stack, stack_size, flags, arg, /* ptid */ NULL,
> +		/* tls */ NULL, /* ctid  */ NULL);
>  # else
>  #  if _STACK_GROWS_DOWN
>    r = clone (fn, stack + stack_size, flags, arg, /* ptid */ NULL,
>  	     /* tls */ NULL, /* ctid */  NULL);
>  #  elif _STACK_GROWS_UP
> -  r = clone (fn, stack, flags, arg, /* ptid */ NULL, /* tls */ NULL,
> -	     &ctid);
> +  r = clone (fn, stack, flags, arg, /* ptid */ NULL, /* tls */ NULL, NULL);
>  #  endif
>  # endif

Thanks for catching it.

      reply	other threads:[~2021-06-25 12:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25  8:24 Florian Weimer
2021-06-25 12:37 ` Adhemerval Zanella [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe796f6a-962c-0e7e-eb00-680af0dad537@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).