From: Palmer Dabbelt <palmer@rivosinc.com>
To: joseph@codesourcery.com
Cc: libc-alpha@sourceware.org, kai.wang@sifive.com, vincent.chen@sifive.com
Subject: Re: [COMMITTED 1/2] riscv: Resolve symbols directly for symbols with STO_RISCV_VARIANT_CC.
Date: Fri, 28 Apr 2023 10:50:41 -0700 (PDT) [thread overview]
Message-ID: <mhng-0d9fb5a0-63fa-4b02-8029-7c20232f39ee@palmer-ri-x1c9> (raw)
In-Reply-To: <be618d5-e079-bf61-a236-d7405406f78@codesourcery.com>
On Fri, 28 Apr 2023 10:45:04 PDT (-0700), joseph@codesourcery.com wrote:
> How was this tested? I've seeing test failures (for all
> build-many-glibcs.py configurations) that look like they were caused by
> this patch.
>
> FAIL: elf/tst-glibcelf
> FAIL: elf/tst-relro-ldso
> FAIL: elf/tst-relro-libc
>
> /scratch/jmyers/glibc-bot/src/glibc/scripts/../elf/elf.h:4013: error: macro STO_RISCV_VARIANT_CC redefined
> /scratch/jmyers/glibc-bot/src/glibc/scripts/../elf/elf.h:3941: note: location of previous definition
> /scratch/jmyers/glibc-bot/src/glibc/scripts/../elf/elf.h:4023: error: macro DT_RISCV_VARIANT_CC redefined
> /scratch/jmyers/glibc-bot/src/glibc/scripts/../elf/elf.h:3937: note: location of previous definition
> Traceback (most recent call last):
> File "/scratch/jmyers/glibc-bot/src/glibc/elf/tst-glibcelf.py", line 23, in <module>
> import glibcelf
> File "/scratch/jmyers/glibc-bot/src/glibc/scripts/glibcelf.py", line 226, in <module>
> _elf_h = _parse_elf_h()
> File "/scratch/jmyers/glibc-bot/src/glibc/scripts/glibcelf.py", line 223, in _parse_elf_h
> raise IOError('parse error in elf.h')
> OSError: parse error in elf.h
>
> https://sourceware.org/pipermail/libc-testresults/2023q2/011183.html
Sorry about that, I'd just committed it because Kito had asked me to a
bunch of times (he's trying to sort out commit access).
I can just go revert it if you want? Either way I'll go figure out what
I screwed up...
next prev parent reply other threads:[~2023-04-28 17:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 14:04 Palmer Dabbelt
2023-04-28 14:04 ` [COMMITTED 2/2] Remap __GLIBC_FLT_EVAL_METHOD to 0 if __FLT_EVAL_METHOD__ is -1 Palmer Dabbelt
2023-04-28 17:45 ` [COMMITTED 1/2] riscv: Resolve symbols directly for symbols with STO_RISCV_VARIANT_CC Joseph Myers
2023-04-28 17:50 ` Palmer Dabbelt [this message]
[not found] ` <d8613f93-ecef-fa32-3fc1-7cc9c4ff189e@linux.vnet.ibm.com>
2023-05-03 14:46 ` Fwd: " Manjul Mohan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-0d9fb5a0-63fa-4b02-8029-7c20232f39ee@palmer-ri-x1c9 \
--to=palmer@rivosinc.com \
--cc=joseph@codesourcery.com \
--cc=kai.wang@sifive.com \
--cc=libc-alpha@sourceware.org \
--cc=vincent.chen@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).