public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] elf: Update list of RISC-V relocations
@ 2023-06-22 10:26 Andreas Schwab
  2023-06-26 13:28 ` Palmer Dabbelt
  0 siblings, 1 reply; 2+ messages in thread
From: Andreas Schwab @ 2023-06-22 10:26 UTC (permalink / raw)
  To: libc-alpha


---
 elf/elf.h | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/elf/elf.h b/elf/elf.h
index ac7032b7a5..89fc8021e9 100644
--- a/elf/elf.h
+++ b/elf/elf.h
@@ -4002,8 +4002,11 @@ enum
 #define R_RISCV_SET32		56
 #define R_RISCV_32_PCREL	57
 #define R_RISCV_IRELATIVE	58
+#define R_RISCV_PLT32		59
+#define R_RISCV_SET_ULEB128	60
+#define R_RISCV_SUB_ULEB128	61
 
-#define R_RISCV_NUM		59
+#define R_RISCV_NUM		62
 
 /* RISC-V specific values for the st_other field.  */
 #define STO_RISCV_VARIANT_CC	0x80	/* Function uses variant calling
-- 
2.41.0


-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] elf: Update list of RISC-V relocations
  2023-06-22 10:26 [PATCH] elf: Update list of RISC-V relocations Andreas Schwab
@ 2023-06-26 13:28 ` Palmer Dabbelt
  0 siblings, 0 replies; 2+ messages in thread
From: Palmer Dabbelt @ 2023-06-26 13:28 UTC (permalink / raw)
  To: schwab; +Cc: libc-alpha

On Thu, 22 Jun 2023 03:26:34 PDT (-0700), schwab@suse.de wrote:
>
> ---
>  elf/elf.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/elf/elf.h b/elf/elf.h
> index ac7032b7a5..89fc8021e9 100644
> --- a/elf/elf.h
> +++ b/elf/elf.h
> @@ -4002,8 +4002,11 @@ enum
>  #define R_RISCV_SET32		56
>  #define R_RISCV_32_PCREL	57
>  #define R_RISCV_IRELATIVE	58
> +#define R_RISCV_PLT32		59
> +#define R_RISCV_SET_ULEB128	60
> +#define R_RISCV_SUB_ULEB128	61
>
> -#define R_RISCV_NUM		59
> +#define R_RISCV_NUM		62
>
>  /* RISC-V specific values for the st_other field.  */
>  #define STO_RISCV_VARIANT_CC	0x80	/* Function uses variant calling

This looks good to me: it's not quite official in the psABI (there's no 
release yet), but given that we're in a grey area WRT compatibility with 
the spec I think it's fine to just stop worrying about the procedures 
over there.  Binutils is going to start producing the ULEB relocations 
for the next release anyway, so at that point it'll be defacto stable 
ABI.

Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
Acked-by: Palmer Dabbelt <palmer@rivosinc.com>

Thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-06-26 13:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-22 10:26 [PATCH] elf: Update list of RISC-V relocations Andreas Schwab
2023-06-26 13:28 ` Palmer Dabbelt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).