From: Andreas Schwab <schwab@suse.de>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v3] io: Fix record locking contants for powerpc64 with __USE_FILE_OFFSET64
Date: Thu, 07 Sep 2023 09:28:39 +0200 [thread overview]
Message-ID: <mvm7cp2zbko.fsf@suse.de> (raw)
In-Reply-To: <20230831191541.2271412-1-aurelien@aurel32.net> (Aurelien Jarno's message of "Thu, 31 Aug 2023 21:15:42 +0200")
On Aug 31 2023, Aurelien Jarno wrote:
> Commit 5f828ff824e3b7cd1 ("io: Fix F_GETLK, F_SETLK, and F_SETLKW for
> powerpc64") fixed an issue with the value of the lock constants on
> powerpc64 when not using __USE_FILE_OFFSET64, but it ended-up also
> changing the value when using __USE_FILE_OFFSET64 causing an API change.
>
> Fix that by also checking that define, restoring the pre
> 4d0fe291aed3a476a commit values:
>
> Default values:
> - F_GETLK: 5
> - F_SETLK: 6
> - F_SETLKW: 7
>
> With -D_FILE_OFFSET_BITS=64:
> - F_GETLK: 12
> - F_SETLK: 13
> - F_SETLKW: 14
>
> At the same time, it has been noticed that there was no test for io lock
> with __USE_FILE_OFFSET64, so just add one.
Ok.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
prev parent reply other threads:[~2023-09-07 7:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 19:15 Aurelien Jarno
2023-09-06 21:09 ` Aurelien Jarno
2023-09-07 7:28 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvm7cp2zbko.fsf@suse.de \
--to=schwab@suse.de \
--cc=aurelien@aurel32.net \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).