From: Andreas Schwab <schwab@suse.de>
To: Letu Ren via Libc-alpha <libc-alpha@sourceware.org>
Cc: Letu Ren <fantasquex@gmail.com>,
fweimer@redhat.com, joseph@codesourcery.com
Subject: Re: [PATCH v4] stdlib/strfrom: Add copysign to fix NAN issue on riscv (BZ #29501)
Date: Thu, 06 Oct 2022 15:42:23 +0200 [thread overview]
Message-ID: <mvmsfk1f4qo.fsf@suse.de> (raw)
In-Reply-To: <20221006132218.14696-1-fantasquex@gmail.com> (Letu Ren via Libc-alpha's message of "Thu, 6 Oct 2022 21:22:18 +0800")
On Okt 06 2022, Letu Ren via Libc-alpha wrote:
> @@ -61,7 +62,7 @@ STRFROM (char *dest, size_t size, const char *format, FLOAT f)
> because __printf_fp and __printf_fphex only accept double and long double
> as the floating-point argument. */
> if (__builtin_types_compatible_p (FLOAT, float))
> - fpnum.flt = f;
> + fpnum.flt = keep_sign_conversion(f);
Style: space before paren.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
prev parent reply other threads:[~2022-10-06 13:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 13:22 Letu Ren
2022-10-06 13:42 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmsfk1f4qo.fsf@suse.de \
--to=schwab@suse.de \
--cc=fantasquex@gmail.com \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).