public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
Cc: Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH] Linux: Fix enum fsconfig_command detection in <sys/mount.h>
Date: Tue, 16 Aug 2022 11:44:34 +0200	[thread overview]
Message-ID: <mvmsflwh69p.fsf@suse.de> (raw)
In-Reply-To: <87a684ejbj.fsf@oldenburg.str.redhat.com> (Florian Weimer via Libc-alpha's message of "Tue, 16 Aug 2022 09:30:56 +0200")

On Aug 16 2022, Florian Weimer via Libc-alpha wrote:

> The #ifdef FSOPEN_CLOEXEC check did not work because the macro
> was defined prior to its use.

This is confusing, since generally we want macros to be defined before
their use.  What's important here is that the use is about checking for
absence of the macro in the kernel header.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

  reply	other threads:[~2022-08-16  9:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-16  7:30 Florian Weimer
2022-08-16  9:44 ` Andreas Schwab [this message]
2022-08-16  9:51   ` Florian Weimer
2022-08-16 10:00     ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mvmsflwh69p.fsf@suse.de \
    --to=schwab@suse.de \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).