* [PATCH] Remove obsolete comments/name from several benchtest input files.
@ 2021-08-02 13:19 Paul Zimmermann
2021-08-02 13:22 ` Siddhesh Poyarekar
0 siblings, 1 reply; 3+ messages in thread
From: Paul Zimmermann @ 2021-08-02 13:19 UTC (permalink / raw)
To: libc-alpha
These comments refer to slow paths that were removed in
glibc 2.34 or earlier. The corresponding "names" that yield
separate workload traces for "make bench" are thus obsolete.
We are however keeping the corresponding inputs.
---
benchtests/asin-inputs | 3 ---
benchtests/atan-inputs | 3 ---
benchtests/cos-inputs | 3 ---
benchtests/pow-inputs | 4 ----
benchtests/sin-inputs | 3 ---
benchtests/tan-inputs | 7 -------
6 files changed, 23 deletions(-)
diff --git a/benchtests/asin-inputs b/benchtests/asin-inputs
index 753049bfe7..9d1a329eea 100644
--- a/benchtests/asin-inputs
+++ b/benchtests/asin-inputs
@@ -2501,9 +2501,6 @@
-0x1.e8ac5756ef915p-1
-0x1.0f9400d75348bp-16
0x1.916dc64eee2aap-1
-# asin multiple precision fallback path
-# Implemented in __sin32 in sysdeps/ieee754/dbl-64/sincos32.c
-## name: slow
0x1.c88b2415431cbp-23
0x1.84a360ccf288dp-20
0x1.7eff5496b7ed2p-21
diff --git a/benchtests/atan-inputs b/benchtests/atan-inputs
index 0f0877a3dc..9fba46e926 100644
--- a/benchtests/atan-inputs
+++ b/benchtests/atan-inputs
@@ -801,9 +801,6 @@
-0x1.ead7509b0d69ep26
0x1.86fa30e0b406ep3
-0x1.acd451c3cb8b6p49
-# atan slow path with 144bit precision
-# Implemented in sysdeps/ieee754/dbl-64/mpatan.c
-## name: 144bits
0x1.000000c5cba87p0
0x1.000001883003bp0
0x1.00000dfb2b675p0
diff --git a/benchtests/cos-inputs b/benchtests/cos-inputs
index 9fc4537446..0252a800a6 100644
--- a/benchtests/cos-inputs
+++ b/benchtests/cos-inputs
@@ -2301,9 +2301,6 @@
0x1.31fad3c41d123p34
-0x1.6757e2c0a08a7p11
0x1.7f07e07a0a269p288
-# cos slow path at 768 bits
-# Implemented in sysdeps/ieee754/dbl-64/sincos32.c
-## name: 768bits
0x1.000000cf4a2a2p0
0x1.0000010b239a9p0
0x1.00000162a932bp0
diff --git a/benchtests/pow-inputs b/benchtests/pow-inputs
index a279ac2d37..4e81d53896 100644
--- a/benchtests/pow-inputs
+++ b/benchtests/pow-inputs
@@ -302,8 +302,6 @@
0x1.c004d2256a5b8p402, -0x1.a01df480fdcb7p98
0x1.52b9d41aaa1e9p-589, -0x1.292cb15f1459dp46
-0x1.ea9ca6fa0919ep-279, -0x1.601e44b6a588cp40
-# old pow slow path at 240 bits
-## name: 240bits
0x1.01fcd33493ea3p596, -0x1.724bd4e887783p-14
0x1.032ff59ab34fdp-540, -0x1.61e3632080b87p-24
0x1.045c337b80f53p304, 0x1.dc3404c30fa69p-56
@@ -404,8 +402,6 @@
0x1.fae913d4f952ep-809, -0x1.4b649402fce63p-6
0x1.fe6d725408f24p484, -0x1.25f4f6441d2e4p-12
0x1.ff6393f9150ccp-718, 0x1.a0cb50a9bf2f3p-31
-# old pow slowest path at 768 bits
-## name: 768bits
1.0000000000000020, 1.5
0x1.006777b4b61dep843, -0x1.67e3145491872p-1
0x1.0477a5cfb1972p-402, 0x1.8742e7a1ce99dp-1
diff --git a/benchtests/sin-inputs b/benchtests/sin-inputs
index 3e7cc3d00f..22f9a5cbe9 100644
--- a/benchtests/sin-inputs
+++ b/benchtests/sin-inputs
@@ -2801,9 +2801,6 @@
0x1.77e333e16d85dp13
0x1.ee51c6871309bp605
-0x1.c61080b14654fp0
-# sin slowest path at 768 bits
-# Implemented in sysdeps/ieee754/dbl-64/sincos32.c
-## name: 768bits
0.93340582292648832662962377071381
2.3328432680770916363144351635128
3.7439477503636453548097051680088
diff --git a/benchtests/tan-inputs b/benchtests/tan-inputs
index 982c2610a1..5a746550ec 100644
--- a/benchtests/tan-inputs
+++ b/benchtests/tan-inputs
@@ -3244,10 +3244,6 @@
-0x1.2a3e75ea2ae07p2
-0x1.90fb35edc8d06p0
0x1.9a76161e739c7p0
-# tan slow path at 240 bits
-# Implemented in sysdeps/ieee754/dbl-64/mptan.c
-# Range reduction is done using mp arithmetic.
-## name: 240bits
0x1.ee5a221c1ec30p750
0x1.d0b7237b90954p983
0x1.50aee539c99e6p817
@@ -3448,9 +3444,6 @@
-0x1.8698a10662bffp544
0x1.a07c20fa799d8p622
-0x1.d126c657c582bp880
-# tan slowest path at 768 bits
-# Implemented in sysdeps/ieee754/dbl-64/mptan.c
-## name: 768bits
0x1.dffffffffff1fp-22
0x1.810f60836538dp143
-0x1.e877a52501e08p134
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove obsolete comments/name from several benchtest input files.
2021-08-02 13:19 [PATCH] Remove obsolete comments/name from several benchtest input files Paul Zimmermann
@ 2021-08-02 13:22 ` Siddhesh Poyarekar
2021-08-02 13:26 ` Paul Zimmermann
0 siblings, 1 reply; 3+ messages in thread
From: Siddhesh Poyarekar @ 2021-08-02 13:22 UTC (permalink / raw)
To: Paul Zimmermann, libc-alpha
On 8/2/21 6:49 PM, Paul Zimmermann wrote:
> These comments refer to slow paths that were removed in
> glibc 2.34 or earlier. The corresponding "names" that yield
> separate workload traces for "make bench" are thus obsolete.
> We are however keeping the corresponding inputs.
LGTM.
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove obsolete comments/name from several benchtest input files.
2021-08-02 13:22 ` Siddhesh Poyarekar
@ 2021-08-02 13:26 ` Paul Zimmermann
0 siblings, 0 replies; 3+ messages in thread
From: Paul Zimmermann @ 2021-08-02 13:26 UTC (permalink / raw)
To: Siddhesh Poyarekar; +Cc: libc-alpha
thank you Siddhesh for your review, I'll commit that patch.
Paul
> From: Siddhesh Poyarekar <siddhesh@gotplt.org>
> Date: Mon, 2 Aug 2021 18:52:51 +0530
>
> On 8/2/21 6:49 PM, Paul Zimmermann wrote:
> > These comments refer to slow paths that were removed in
> > glibc 2.34 or earlier. The corresponding "names" that yield
> > separate workload traces for "make bench" are thus obsolete.
> > We are however keeping the corresponding inputs.
>
> LGTM.
>
> Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-02 13:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-02 13:19 [PATCH] Remove obsolete comments/name from several benchtest input files Paul Zimmermann
2021-08-02 13:22 ` Siddhesh Poyarekar
2021-08-02 13:26 ` Paul Zimmermann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).