From: Paul Zimmermann <Paul.Zimmermann@inria.fr>
To: Joseph Myers <josmyers@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: Implement C23 log2p1
Date: Wed, 10 Apr 2024 16:46:08 +0200 [thread overview]
Message-ID: <p9u0h6g9z367.fsf@araignee.loria.fr> (raw)
In-Reply-To: <ae7c7c61-c5a9-3910-62b7-28e57e76428@redhat.com> (message from Joseph Myers on Wed, 10 Apr 2024 14:34:09 +0000 (UTC))
Hi Joseph,
I would prefer that you submit a v2 including the inputs yielding larger
errors that I pointed out in my review.
Paul
> Date: Wed, 10 Apr 2024 14:34:09 +0000 (UTC)
> From: Joseph Myers <josmyers@redhat.com>
> cc: libc-alpha@sourceware.org
>
> On Wed, 10 Apr 2024, Paul Zimmermann wrote:
>
> > Dear Joseph,
> >
> > I tried your patch on a x86_64, it applies cleanly, everything compiles
> > cleanly, and I can use the new log2p1 function in both binary32, binary64,
> > double-extended and binary128.
> >
> > As for accuracy, here are the largest errors I found for rounding to nearest:
>
> In general I encourage adding extra tests to auto-libm-test-in where they
> show errors, for any implementation in glibc, larger than those inputs
> already present (but not so large that they cannot be entered in
> libm-test-ulps files). So adding such inputs for log2p1 would be
> appropriate after this patch is in, and the same applies for all the other
> C23 functions as they get added.
>
> --
> Joseph S. Myers
> josmyers@redhat.com
>
>
next prev parent reply other threads:[~2024-04-10 14:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 21:19 Joseph Myers
2024-04-10 8:31 ` Paul Zimmermann
2024-04-10 14:34 ` Joseph Myers
2024-04-10 14:46 ` Paul Zimmermann [this message]
2024-04-10 15:00 ` Joseph Myers
2024-04-15 13:41 ` Carlos O'Donell
2024-04-15 13:52 ` Adhemerval Zanella Netto
2024-04-18 13:26 ` Joseph Myers
2024-04-29 13:34 ` Ping " Joseph Myers
2024-04-29 13:51 ` Paul Zimmermann
2024-05-07 21:34 ` Ping^2 " Joseph Myers
2024-05-16 16:47 ` Ping^3 " Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p9u0h6g9z367.fsf@araignee.loria.fr \
--to=paul.zimmermann@inria.fr \
--cc=josmyers@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).