Re: [PATCH 2/2] localedata: Do not generate output if warnings were present.

[DJ Delorie <dj@redhat.com>]

"Carlos O'Donell via Libc-alpha" <libc-alpha@sourceware.org> writes:
> diff --git a/localedata/Makefile b/localedata/Makefile
>  $(INSTALL-SUPPORTED-LOCALE-ARCHIVE): install-locales-dir
> -	@flags="-c"; \
>  	$(build-one-locale)

Ok.  (or do we set this to "" ?)

>  $(INSTALL-SUPPORTED-LOCALE-FILES): install-locales-dir
> -	@flags="-c --no-archive --no-hard-links"; \
> +	@flags="--no-archive --no-hard-links"; \
>  	$(build-one-locale)

Ok.

> diff --git a/localedata/gen-locale.sh b/localedata/gen-locale.sh
> -# Run quietly and force output.
> -flags="--quiet -c"
> +# Do not force output with '-c', all locales should compile without
> +# warning or errors.  There is likewise no need to run quietly with
> +# '--quiet' since all locales should compile without additional
> +# diagnostics.  If there are messages printed then we want to see
> +# them, fix them, and the associated error or warning.  During
> +# development it may be beneficialy to put '--quiet -c' here to allow
> +# you to develop in-progress locales.
> +flags=""

Ok, but this assumes that all locales are fully defined, with no fields
left to their defaults.

LGTM
Reviewed-by: DJ Delorie <dj@redhat.com>