public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: DJ Delorie <dj@redhat.com>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] malloc: Use correct C11 atomics for fastbin
Date: Tue, 06 Dec 2022 11:23:46 -0500	[thread overview]
Message-ID: <xncz8w5wml.fsf@greed.delorie.com> (raw)
In-Reply-To: <PAWPR08MB89820A2AA92B6692C064CF38831B9@PAWPR08MB8982.eurprd08.prod.outlook.com>

Wilco Dijkstra <Wilco.Dijkstra@arm.com> writes:
>>> You can test that with a tunable; the max count per bin is runtime
>>> tunable.
>
> Yes you can use tunables, but how many applications actually use more
> optimized settings? It's the default that is the problem.

If testing shows that a larger default makes sense across a wide range
of applications, then we can change the default.  I'm a bit opposed to
changing anything because "it makes sense".  Back it up with data.

> Yes, that's due the tiny size of tcache (let's call it
> tiny-cache!). Once exhausted, you mostly end up using the fastbins.

tcache is wide but shallow, fastbins are narrow but deep (tcache caches
much larger chunks than fastbins do) Benchmarks show they both provide a
speed boost separately, and more so when combined.

> Modern allocators are not only much faster than GLIBC in their default
> settings

Back this up with data please.  Tcache invalidated most online
benchmarks.

> but also have lower memory usage.

This is a project we've got on our to-do list.


  parent reply	other threads:[~2022-12-06 16:23 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-21 16:09 Wilco Dijkstra
2022-11-21 16:18 ` Florian Weimer
2022-11-21 16:55   ` Wilco Dijkstra
2022-11-21 16:56     ` Wilco Dijkstra
2022-11-21 17:00     ` Florian Weimer
2022-12-02  5:11 ` DJ Delorie
2022-12-02  6:36   ` Florian Weimer
2022-12-02 10:56     ` Wilco Dijkstra
2022-12-02 11:24       ` Florian Weimer
2022-12-02 12:02         ` Wilco Dijkstra
2022-12-02 18:55           ` DJ Delorie
2022-12-05 18:39             ` Zack Weinberg
2022-12-06 16:19               ` DJ Delorie
2022-12-12  3:35                 ` Zack Weinberg
2022-12-12 11:57                   ` Florian Weimer
2022-12-12 11:56                 ` Florian Weimer
2022-12-06 13:29             ` Wilco Dijkstra
2022-12-06 13:37               ` Adhemerval Zanella Netto
2022-12-06 14:31                 ` Zack Weinberg
2022-12-06 16:23               ` DJ Delorie [this message]
2022-12-15 15:43                 ` Wilco Dijkstra
2022-12-02 18:55     ` DJ Delorie
2022-12-06 15:04 Wilco Dijkstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xncz8w5wml.fsf@greed.delorie.com \
    --to=dj@redhat.com \
    --cc=Wilco.Dijkstra@arm.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).