From: DJ Delorie <dj@redhat.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [patch v3] Allow for unpriviledged nested containers
Date: Thu, 18 Nov 2021 14:52:04 -0500 [thread overview]
Message-ID: <xnv90p1btn.fsf@greed.delorie.com> (raw)
In-Reply-To: <87a6i1dz59.fsf@oldenburg.str.redhat.com>
Florian Weimer <fweimer@redhat.com> writes:
>> Well, for the pldd test, obviously we do ;-)
>
> Do we? /proc and the PIDs of the processes have to be consistent for
> sure, but do we really need them to be separate from the host?
It's the consistency that's the problem. If getpid() (which returns a
pid in the child namespace) returns a value that's useless in
/proc/<pid> (because those are pids in the parent namespace) then the
test fails.
One process can have different PIDs depending on how you look at it.
>> 1. No /proc
>> 2. /proc in wrong namespace
>> 3. /proc in correct namespace
>>
>> We'd prefer 3, then 1, but not 2?
>
> Yeah, 2 is quite bad for some tests at least. Some thread-exit tests
> will suffer as well, I think, because they read TIDs from
> /proc/self/task.
3-then-1 returns us to my original patch, which attempted to mount it in
the child namespace, or failed but let the test run anyway.
next prev parent reply other threads:[~2021-11-18 19:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 23:08 DJ Delorie
2021-11-17 11:06 ` Florian Weimer
2021-11-17 22:44 ` DJ Delorie
2021-11-18 11:35 ` Florian Weimer
2021-11-18 18:37 ` DJ Delorie
2021-11-18 19:47 ` Florian Weimer
2021-11-18 19:52 ` DJ Delorie [this message]
2021-11-18 19:55 ` Florian Weimer
2021-11-18 20:18 ` DJ Delorie
2021-11-18 20:20 ` Florian Weimer
2021-11-18 20:25 ` DJ Delorie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xnv90p1btn.fsf@greed.delorie.com \
--to=dj@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).