missing libc_hidden_proto() declarations?

missing libc_hidden_proto() declarations?

[David Mosberger]

I had to declare if_nametoindex() and if_indextoname() with
libc_hidden_proto() to get libc to compile on ia64 linux (with
gcc-pre3.4).  Since this seems to work for others, perhaps I'm doing
something wrong?

	--david

2003-01-13  David Mosberger  <davidm@hpl.hp.com>

	* sysdeps/gnu/net/if.h (if_nametoindex): Mark as libc_hidden_proto.
	(if_indextoname): Likewise.

Index: sysdeps/gnu/net/if.h
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/gnu/net/if.h,v
retrieving revision 1.5
diff -u -r1.5 if.h
--- sysdeps/gnu/net/if.h	6 Jul 2001 04:55:51 -0000	1.5
+++ sysdeps/gnu/net/if.h	14 Jan 2003 06:46:50 -0000
@@ -192,6 +192,9 @@
 extern unsigned int if_nametoindex (__const char *__ifname) __THROW;
 extern char *if_indextoname (unsigned int __ifindex, char *__ifname) __THROW;
 
+libc_hidden_proto (if_nametoindex);
+libc_hidden_proto (if_indextoname);
+
 /* Return a list of all interfaces and their indices.  */
 extern struct if_nameindex *if_nameindex (void) __THROW;
 

Re: missing libc_hidden_proto() declarations?

[Jakub Jelinek]

On Mon, Jan 13, 2003 at 10:57:55PM -0800, David Mosberger wrote:
> I had to declare if_nametoindex() and if_indextoname() with
> libc_hidden_proto() to get libc to compile on ia64 linux (with
> gcc-pre3.4).  Since this seems to work for others, perhaps I'm doing
> something wrong?

libc/include/net/if.h has:
#ifndef _NET_IF_H

# include_next <net/if.h>

libc_hidden_proto (if_nametoindex)
libc_hidden_proto (if_indextoname)

#endif

which should take care of this.
So you should investigate why include/net/if.h has not been included.

	Jakub

Re: missing libc_hidden_proto() declarations?

[David Mosberger]

>>>>> On Tue, 14 Jan 2003 08:16:14 +0100, Jakub Jelinek <jakub@redhat.com> said:

  Jakub> On Mon, Jan 13, 2003 at 10:57:55PM -0800, David Mosberger
  Jakub> wrote:
  >> I had to declare if_nametoindex() and if_indextoname() with
  >> libc_hidden_proto() to get libc to compile on ia64 linux (with
  >> gcc-pre3.4).  Since this seems to work for others, perhaps I'm
  >> doing something wrong?

  Jakub> libc/include/net/if.h has: #ifndef _NET_IF_H

  Jakub> # include_next <net/if.h>

  Jakub> libc_hidden_proto (if_nametoindex) libc_hidden_proto
  Jakub> (if_indextoname)

  Jakub> #endif

  Jakub> which should take care of this.  So you should investigate
  Jakub> why include/net/if.h has not been included.

The file include/net/if.h doesn't exist in my tree.  I'm probably
doing something wrong with cvs.  Is there a reason why "cvs update"
wouldn't pick up this (presumably new) file?

	--david

Re: missing libc_hidden_proto() declarations?

[Ulrich Drepper]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

David Mosberger wrote:

> The file include/net/if.h doesn't exist in my tree.  I'm probably
> doing something wrong with cvs.  Is there a reason why "cvs update"
> wouldn't pick up this (presumably new) file?

It's in a new directory.  Add -d after cvs update.

- -- 
- --------------.                        ,-.            444 Castro Street
Ulrich Drepper \    ,-----------------'   \ Mountain View, CA 94041 USA
Red Hat         `--' drepper at redhat.com `---------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+I8AL2ijCOnn/RHQRAkDjAJ9aF/zqP6Jq97gZ8RExAtDMJfRVOQCfRaBo
maqSi097eZbWl/ZihiBFPkQ=
=6TpD
-----END PGP SIGNATURE-----

Re: missing libc_hidden_proto() declarations?

[David Mosberger]

>>>>> On Tue, 14 Jan 2003 07:45:15 +0000, Ulrich Drepper <drepper@redhat.com> said:

  Uli> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

  Uli> David Mosberger wrote:

  >> The file include/net/if.h doesn't exist in my tree.  I'm probably
  >> doing something wrong with cvs.  Is there a reason why "cvs
  >> update" wouldn't pick up this (presumably new) file?

  Uli> It's in a new directory.  Add -d after cvs update.

That did the trick.  Thanks!

	--david