From: David Mosberger <davidm@napali.hpl.hp.com>
To: Roland McGrath <roland@redhat.com>
Cc: davidm@hpl.hp.com, libc-hacker@sources.redhat.com
Subject: Re: second thoughts on using dl_iterate_phdr() for cache-validation
Date: Fri, 05 Nov 2004 00:40:00 -0000 [thread overview]
Message-ID: <16778.52238.419635.428364@napali.hpl.hp.com> (raw)
In-Reply-To: <200411042353.iA4NrtN1029576@magilla.sf.frob.com>
>>>>> On Thu, 4 Nov 2004 15:53:55 -0800, Roland McGrath <roland@redhat.com> said:
Roland> No new ABI is going to go in very soon. We have frozen the
Roland> GLIBC_2.3.4 ABI already.
That's unfortunate.
Is there a mechanism to queue this patch so it doesn't get lost again
when 2.3.5 is opened up?
Roland> unsigned long long int is not an atomic type on all
Roland> platforms, so your code as written is not acceptable without
Roland> adding locking for machines where it's not.
The incrementing is always done under protection of a lock. The reading
is not, but on those machines where reading an "unsigned long long int"
isn't atomic, the effect is no worse than when using "unsigned int".
And on those machines where it is atomic, "unsigned long long int" pretty
much guarantees that the counter will never overflow.
Do you still think the patch is unacceptable in this regard?
Roland> An interface to return the address of such variables is
Roland> highly dubious, since it constrains the implementation and
Roland> does so permanently for the future.
OK, I see your point.
Thanks,
--david
next prev parent reply other threads:[~2004-11-05 0:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-31 8:53 David Mosberger
2004-03-31 16:04 ` Roland McGrath
2004-04-01 2:33 ` David Mosberger
2004-11-04 23:41 ` David Mosberger
2004-11-04 23:53 ` Roland McGrath
2004-11-05 0:40 ` David Mosberger [this message]
2004-11-05 1:10 ` Roland McGrath
2004-11-05 1:28 ` David Mosberger
2004-11-05 1:36 ` Roland McGrath
2004-11-05 2:09 ` David Mosberger
2004-11-05 3:27 ` Roland McGrath
2004-11-06 0:21 ` David Mosberger
2004-11-06 2:32 ` Roland McGrath
2004-11-09 0:15 ` David Mosberger
2004-11-09 4:40 ` Roland McGrath
2004-11-10 5:40 ` David Mosberger
2004-11-10 20:36 ` David Mosberger
2004-11-10 20:45 ` Roland McGrath
2004-11-11 6:17 ` David Mosberger
2004-11-11 22:24 ` Roland McGrath
2004-11-12 19:32 ` David Mosberger
2004-04-15 18:28 David Mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16778.52238.419635.428364@napali.hpl.hp.com \
--to=davidm@napali.hpl.hp.com \
--cc=davidm@hpl.hp.com \
--cc=libc-hacker@sources.redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).