public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: davidm@hpl.hp.com
Cc: libc-hacker@sources.redhat.com
Subject: Re: second thoughts on using dl_iterate_phdr() for cache-validation
Date: Thu, 04 Nov 2004 23:53:00 -0000	[thread overview]
Message-ID: <200411042353.iA4NrtN1029576@magilla.sf.frob.com> (raw)
In-Reply-To: David Mosberger's message of  Thursday, 4 November 2004 15:41:39 -0800 <16778.48691.899903.792304@napali.hpl.hp.com>

No new ABI is going to go in very soon.  We have frozen the GLIBC_2.3.4 ABI
already.  (Your patch adds symbols to a version set that has been fixed for
a long time, which is never a kind of patch that would be accepted.)

unsigned long long int is not an atomic type on all platforms, so your code
as written is not acceptable without adding locking for machines where it's
not.  It seems preferable to just used unsigned long int instead, which it
is safe to increment and examine simultaneously on all the platforms we have.

An interface to return the address of such variables is highly dubious,
since it constrains the implementation and does so permanently for the future.

  reply	other threads:[~2004-11-04 23:53 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-31  8:53 David Mosberger
2004-03-31 16:04 ` Roland McGrath
2004-04-01  2:33   ` David Mosberger
2004-11-04 23:41     ` David Mosberger
2004-11-04 23:53       ` Roland McGrath [this message]
2004-11-05  0:40         ` David Mosberger
2004-11-05  1:10           ` Roland McGrath
2004-11-05  1:28             ` David Mosberger
2004-11-05  1:36               ` Roland McGrath
2004-11-05  2:09                 ` David Mosberger
2004-11-05  3:27                   ` Roland McGrath
2004-11-06  0:21                     ` David Mosberger
2004-11-06  2:32                       ` Roland McGrath
2004-11-09  0:15                         ` David Mosberger
2004-11-09  4:40                           ` Roland McGrath
2004-11-10  5:40                             ` David Mosberger
2004-11-10 20:36                               ` David Mosberger
2004-11-10 20:45                               ` Roland McGrath
2004-11-11  6:17                                 ` David Mosberger
2004-11-11 22:24                                   ` Roland McGrath
2004-11-12 19:32                                     ` David Mosberger
2004-04-15 18:28 David Mosberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200411042353.iA4NrtN1029576@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=davidm@hpl.hp.com \
    --cc=libc-hacker@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).