public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
* Do we need Linux/alpha and Linux/sparc versions of <bits/siginfo.h>?
@ 2000-01-23 23:15 Andreas Jaeger
  2000-01-23 23:45 ` Jakub Jelinek
  0 siblings, 1 reply; 4+ messages in thread
From: Andreas Jaeger @ 2000-01-23 23:15 UTC (permalink / raw)
  To: GNU libc hacker

Looking through the various asm-*/siginfo.h files in Linux 2.3.41pre2,
I've encountered only two platforms with problems: Alpha and Sparc.
Could the maintainers of these platforms please check the following
and take appropriate action?

Alpha defines:
#define SI_PAD_SIZE     ((SI_MAX_SIZE/sizeof(int)) - 4)
#define SIGEV_PAD_SIZE  ((SIGEV_MAX_SIZE/sizeof(int)) - 4)

but all other platforms have a 3 instead of a 4 for these two defines:
#define SI_PAD_SIZE     ((SI_MAX_SIZE/sizeof(int)) - 3)
#define SIGEV_PAD_SIZE  ((SIGEV_MAX_SIZE/sizeof(int)) - 3)

Sparc and Sparc64 additionally define the member _trapno for _sigfault
- and SIGEMT is also only used by Sparc*:
                /* SIGILL, SIGFPE, SIGSEGV, SIGBUS, SIGEMT */
                struct {
                        void *_addr;    /* faulting insn/memory ref. */
                        int  _trapno;   /* TRAP # which caused the signal */
                } _sigfault;


Do we need Linux/alpha and Linux/sparc versions of <bits/siginfo.h>?

Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.rhein-neckar.de

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Do we need Linux/alpha and Linux/sparc versions of <bits/siginfo.h>?
  2000-01-23 23:15 Do we need Linux/alpha and Linux/sparc versions of <bits/siginfo.h>? Andreas Jaeger
@ 2000-01-23 23:45 ` Jakub Jelinek
  2000-01-23 23:56   ` Andreas Jaeger
  0 siblings, 1 reply; 4+ messages in thread
From: Jakub Jelinek @ 2000-01-23 23:45 UTC (permalink / raw)
  To: Andreas Jaeger; +Cc: GNU libc hacker

On Mon, Jan 24, 2000 at 08:14:29AM +0100, Andreas Jaeger wrote:
> 
> Looking through the various asm-*/siginfo.h files in Linux 2.3.41pre2,
> I've encountered only two platforms with problems: Alpha and Sparc.
> Could the maintainers of these platforms please check the following
> and take appropriate action?
> 
> Alpha defines:
> #define SI_PAD_SIZE     ((SI_MAX_SIZE/sizeof(int)) - 4)
> #define SIGEV_PAD_SIZE  ((SIGEV_MAX_SIZE/sizeof(int)) - 4)
> 
> but all other platforms have a 3 instead of a 4 for these two defines:
> #define SI_PAD_SIZE     ((SI_MAX_SIZE/sizeof(int)) - 3)
> #define SIGEV_PAD_SIZE  ((SIGEV_MAX_SIZE/sizeof(int)) - 3)
> 
> Sparc and Sparc64 additionally define the member _trapno for _sigfault
> - and SIGEMT is also only used by Sparc*:
>                 /* SIGILL, SIGFPE, SIGSEGV, SIGBUS, SIGEMT */
>                 struct {
>                         void *_addr;    /* faulting insn/memory ref. */
>                         int  _trapno;   /* TRAP # which caused the signal */
>                 } _sigfault;
> 
> 
> Do we need Linux/alpha and Linux/sparc versions of <bits/siginfo.h>?

(Again, something which I had scheduled for today anyway).
IMHO, we need only separate version of sparc siginfo, plus use __WORDSIZE
in the generic linux version (I think ia64, ppc64, mips64 etc. could use it
as well):

2000-01-24  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/unix/sysv/linux/bits/siginfo.h (__SI_PAD_SIZE,
	__SIGEV_PAD_SIZE): Define differently on __WORDSIZE == 64 platforms.
	* sysdeps/unix/sysv/linux/sparc/bits/siginfo.h: New file.
	* sysdeps/unix/sysv/linux/sigqueue.c (__sigqueue): Make sure we don't
	send random data from our stack.
	* sysdeps/unix/sysv/linux/aio_sigqueue.c (__aio_sigqueue): Likewise.

--- libc/sysdeps/unix/sysv/linux/bits/siginfo.h.jj	Fri Nov 12 16:30:35 1999
+++ libc/sysdeps/unix/sysv/linux/bits/siginfo.h	Mon Jan 24 08:23:15 2000
@@ -1,5 +1,5 @@
-/* siginfo_t, sigevent and constants.  Linux version.
-   Copyright (C) 1997, 1998, 1999 Free Software Foundation, Inc.
+/* siginfo_t, sigevent and constants.  Linux/SPARC version.
+   Copyright (C) 1997, 1998, 1999, 2000 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -21,6 +21,8 @@
 # error "Never include this file directly.  Use <signal.h> instead"
 #endif
 
+#include <bits/wordsize.h>
+
 #if (!defined __have_siginfo_t \
      && (defined _SIGNAL_H || defined __need_siginfo_t))
 # define __have_siginfo_t	1
@@ -33,7 +35,11 @@ typedef union sigval
   } sigval_t;
 
 # define __SI_MAX_SIZE     128
-# define __SI_PAD_SIZE     ((__SI_MAX_SIZE / sizeof (int)) - 3)
+# if __WORDSIZE == 64
+#  define __SI_PAD_SIZE     ((__SI_MAX_SIZE / sizeof (int)) - 4)
+# else
+#  define __SI_PAD_SIZE     ((__SI_MAX_SIZE / sizeof (int)) - 3)
+# endif
 
 typedef struct siginfo
   {
@@ -245,7 +251,11 @@ enum
 
 /* Structure to transport application-defined values with signals.  */
 # define __SIGEV_MAX_SIZE	64
-# define __SIGEV_PAD_SIZE	((__SIGEV_MAX_SIZE / sizeof (int)) - 3)
+# if __WORDSIZE == 64
+#  define __SIGEV_PAD_SIZE	((__SIGEV_MAX_SIZE / sizeof (int)) - 4)
+# else
+#  define __SIGEV_PAD_SIZE	((__SIGEV_MAX_SIZE / sizeof (int)) - 3)
+# endif
 
 typedef struct sigevent
   {
--- libc/sysdeps/unix/sysv/linux/sparc/bits/siginfo.h.jj	Mon Jan 24 08:14:28 2000
+++ libc/sysdeps/unix/sysv/linux/sparc/bits/siginfo.h	Mon Jan 24 08:22:22 2000
@@ -0,0 +1,302 @@
+/* siginfo_t, sigevent and constants.  Linux/SPARC version.
+   Copyright (C) 1997, 1998, 1999, 2000 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Library General Public License as
+   published by the Free Software Foundation; either version 2 of the
+   License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Library General Public License for more details.
+
+   You should have received a copy of the GNU Library General Public
+   License along with the GNU C Library; see the file COPYING.LIB.  If not,
+   write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
+   Boston, MA 02111-1307, USA.  */
+
+#if !defined _SIGNAL_H && !defined __need_siginfo_t
+# error "Never include this file directly.  Use <signal.h> instead"
+#endif
+
+#include <bits/wordsize.h>
+
+#if (!defined __have_siginfo_t \
+     && (defined _SIGNAL_H || defined __need_siginfo_t))
+# define __have_siginfo_t	1
+
+/* Type for data associated with a signal.  */
+typedef union sigval
+  {
+    int sival_int;
+    void *sival_ptr;
+  } sigval_t;
+
+# define __SI_MAX_SIZE     128
+# if __WORDSIZE == 64
+#  define __SI_PAD_SIZE     ((__SI_MAX_SIZE / sizeof (int)) - 4)
+# else
+#  define __SI_PAD_SIZE     ((__SI_MAX_SIZE / sizeof (int)) - 3)
+# endif
+
+typedef struct siginfo
+  {
+    int si_signo;		/* Signal number.  */
+    int si_errno;		/* If non-zero, an errno value associated with
+				   this signal, as defined in <errno.h>.  */
+    int si_code;		/* Signal code.  */
+
+    union
+      {
+	int _pad[__SI_PAD_SIZE];
+
+	 /* kill().  */
+	struct
+	  {
+	    __pid_t si_pid;	/* Sending process ID.  */
+	    __uid_t si_uid;	/* Real user ID of sending process.  */
+	  } _kill;
+
+	/* POSIX.1b timers.  */
+	struct
+	  {
+	    unsigned int _timer1;
+	    unsigned int _timer2;
+	  } _timer;
+
+	/* POSIX.1b signals.  */
+	struct
+	  {
+	    __pid_t si_pid;	/* Sending process ID.  */
+	    __uid_t si_uid;	/* Real user ID of sending process.  */
+	    sigval_t si_sigval;	/* Signal value.  */
+	  } _rt;
+
+	/* SIGCHLD.  */
+	struct
+	  {
+	    __pid_t si_pid;	/* Which child.  */
+	    __uid_t si_uid;	/* Real user ID of sending process.  */
+	    int si_status;	/* Exit value or signal.  */
+	    __clock_t si_utime;
+	    __clock_t si_stime;
+	  } _sigchld;
+
+	/* SIGILL, SIGFPE, SIGSEGV, SIGBUS.  */
+	struct
+	  {
+	    void *si_addr;	/* Faulting insn/memory ref.  */
+	    int si_trapno;
+	  } _sigfault;
+
+	/* SIGPOLL.  */
+	struct
+	  {
+	    int si_band;	/* Band event for SIGPOLL.  */
+	    int si_fd;
+	  } _sigpoll;
+      } _sifields;
+  } siginfo_t;
+
+
+/* X/Open requires some more fields with fixed names.  */
+# define si_pid		_sifields._kill.si_pid
+# define si_uid		_sifields._kill.si_uid
+# define si_timer1	_sifields._timer._timer1
+# define si_timer2	_sifields._timer._timer2
+# define si_status	_sifields._sigchld.si_status
+# define si_utime	_sifields._sigchld.si_utime
+# define si_stime	_sifields._sigchld.si_stime
+# define si_value	_sifields._rt.si_sigval
+# define si_int		_sifields._rt.si_sigval.sival_int
+# define si_ptr		_sifields._rt.si_sigval.sival_ptr
+# define si_addr	_sifields._sigfault.si_addr
+# define si_trapno	_sifields._sigfault.si_trapno
+# define si_band	_sifields._sigpoll.si_band
+# define si_fd		_sifields._sigpoll.si_fd
+
+
+/* Values for `si_code'.  Positive values are reserved for kernel-generated
+   signals.  */
+enum
+{
+  SI_SIGIO = -5,		/* Sent by queued SIGIO. */
+# define SI_SIGIO	SI_SIGIO
+  SI_ASYNCIO,			/* Sent by AIO completion.  */
+# define SI_ASYNCIO	SI_ASYNCIO
+  SI_MESGQ,			/* Sent by real time mesq state change.  */
+# define SI_MESGQ	SI_MESGQ
+  SI_TIMER,			/* Sent by timer expiration.  */
+# define SI_TIMER	SI_TIMER
+  SI_QUEUE,			/* Sent by sigqueue.  */
+# define SI_QUEUE	SI_QUEUE
+  SI_USER,			/* Sent by kill, sigsend, raise.  */
+# define SI_USER	SI_USER
+  SI_KERNEL = 0x80		/* Send by kernel.  */
+#define SI_KERNEL	SI_KERNEL
+};
+
+
+/* `si_code' values for SIGILL signal.  */
+enum
+{
+  ILL_ILLOPC = 1,		/* Illegal opcode.  */
+# define ILL_ILLOPC	ILL_ILLOPC
+  ILL_ILLOPN,			/* Illegal operand.  */
+# define ILL_ILLOPN	ILL_ILLOPN
+  ILL_ILLADR,			/* Illegal addressing mode.  */
+# define ILL_ILLADR	ILL_ILLADR
+  ILL_ILLTRP,			/* Illegal trap. */
+# define ILL_ILLTRP	ILL_ILLTRP
+  ILL_PRVOPC,			/* Privileged opcode.  */
+# define ILL_PRVOPC	ILL_PRVOPC
+  ILL_PRVREG,			/* Privileged register.  */
+# define ILL_PRVREG	ILL_PRVREG
+  ILL_COPROC,			/* Coprocessor error.  */
+# define ILL_COPROC	ILL_COPROC
+  ILL_BADSTK			/* Internal stack error.  */
+# define ILL_BADSTK	ILL_BADSTK
+};
+
+/* `si_code' values for SIGFPE signal.  */
+enum
+{
+  FPE_INTDIV = 1,		/* Integer divide by zero.  */
+# define FPE_INTDIV	FPE_INTDIV
+  FPE_INTOVF,			/* Integer overflow.  */
+# define FPE_INTOVF	FPE_INTOVF
+  FPE_FLTDIV,			/* Floating point divide by zero.  */
+# define FPE_FLTDIV	FPE_FLTDIV
+  FPE_FLTOVF,			/* Floating point overflow.  */
+# define FPE_FLTOVF	FPE_FLTOVF
+  FPE_FLTUND,			/* Floating point underflow.  */
+# define FPE_FLTUND	FPE_FLTUND
+  FPE_FLTRES,			/* Floating point inexact result.  */
+# define FPE_FLTRES	FPE_FLTRES
+  FPE_FLTINV,			/* Floating point invalid operation.  */
+# define FPE_FLTINV	FPE_FLTINV
+  FPE_FLTSUB			/* Subscript out of range.  */
+# define FPE_FLTSUB	FPE_FLTSUB
+};
+
+/* `si_code' values for SIGSEGV signal.  */
+enum
+{
+  SEGV_MAPERR = 1,		/* Address not mapped to object.  */
+# define SEGV_MAPERR	SEGV_MAPERR
+  SEGV_ACCERR			/* Invalid permissions for mapped object.  */
+# define SEGV_ACCERR	SEGV_ACCERR
+};
+
+/* `si_code' values for SIGBUS signal.  */
+enum
+{
+  BUS_ADRALN = 1,		/* Invalid address alignment.  */
+# define BUS_ADRALN	BUS_ADRALN
+  BUS_ADRERR,			/* Non-existant physical address.  */
+# define BUS_ADRERR	BUS_ADRERR
+  BUS_OBJERR			/* Object specific hardware error.  */
+# define BUS_OBJERR	BUS_OBJERR
+};
+
+/* `si_code' values for SIGTRAP signal.  */
+enum
+{
+  TRAP_BRKPT = 1,		/* Process breakpoint.  */
+# define TRAP_BRKPT	TRAP_BRKPT
+  TRAP_TRACE			/* Process trace trap.  */
+# define TRAP_TRACE	TRAP_TRACE
+};
+
+/* `si_code' values for SIGCHLD signal.  */
+enum
+{
+  CLD_EXITED = 1,		/* Child has exited.  */
+# define CLD_EXITED	CLD_EXITED
+  CLD_KILLED,			/* Child was killed.  */
+# define CLD_KILLED	CLD_KILLED
+  CLD_DUMPED,			/* Child terminated abnormally.  */
+# define CLD_DUMPED	CLD_DUMPED
+  CLD_TRAPPED,			/* Traced child has trapped.  */
+# define CLD_TRAPPED	CLD_TRAPPED
+  CLD_STOPPED,			/* Child has stopped.  */
+# define CLD_STOPPED	CLD_STOPPED
+  CLD_CONTINUED			/* Stopped child has continued.  */
+# define CLD_CONTINUED	CLD_CONTINUED
+};
+
+/* `si_code' values for SIGPOLL signal.  */
+enum
+{
+  POLL_IN = 1,			/* Data input available.  */
+# define POLL_IN	POLL_IN
+  POLL_OUT,			/* Output buffers available.  */
+# define POLL_OUT	POLL_OUT
+  POLL_MSG,			/* Input message available.   */
+# define POLL_MSG	POLL_MSG
+  POLL_ERR,			/* I/O error.  */
+# define POLL_ERR	POLL_ERR
+  POLL_PRI,			/* High priority input available.  */
+# define POLL_PRI	POLL_PRI
+  POLL_HUP			/* Device disconnected.  */
+# define POLL_HUP	POLL_HUP
+};
+
+/* `si_code' values for SIGEMT signal.  */
+enum
+{
+  EMT_TAGOVF = 1		/* Tag overflow.  */
+# define EMT_TAGOVF	EMT_TAGOVF
+};
+
+# undef __need_siginfo_t
+#endif	/* !have siginfo_t && (have _SIGNAL_H || need siginfo_t).  */
+
+
+#if defined _SIGNAL_H && !defined __have_sigevent_t
+# define __have_sigevent_t	1
+
+/* Structure to transport application-defined values with signals.  */
+# define __SIGEV_MAX_SIZE	64
+# if __WORDSIZE == 64
+#  define __SIGEV_PAD_SIZE	((__SIGEV_MAX_SIZE / sizeof (int)) - 4)
+# else
+#  define __SIGEV_PAD_SIZE	((__SIGEV_MAX_SIZE / sizeof (int)) - 3)
+# endif
+
+typedef struct sigevent
+  {
+    sigval_t sigev_value;
+    int sigev_signo;
+    int sigev_notify;
+
+    union
+      {
+	int _pad[__SIGEV_PAD_SIZE];
+
+	struct
+	  {
+	    void (*_function) (sigval_t);	  /* Function to start.  */
+	    void *_attribute;			  /* Really pthread_attr_t.  */
+	  } _sigev_thread;
+      } _sigev_un;
+  } sigevent_t;
+
+/* POSIX names to access some of the members.  */
+# define sigev_notify_function   _sigev_un._sigev_thread._function
+# define sigev_notify_attributes _sigev_un._sigev_thread._attribute
+
+/* `sigev_notify' values.  */
+enum
+{
+  SIGEV_SIGNAL = 0,		/* Notify via signal.  */
+# define SIGEV_SIGNAL	SIGEV_SIGNAL
+  SIGEV_NONE,			/* Other notification: meaningless.  */
+# define SIGEV_NONE	SIGEV_NONE
+  SIGEV_THREAD			/* Deliver via thread creation.  */
+# define SIGEV_THREAD	SIGEV_THREAD
+};
+
+#endif	/* have _SIGNAL_H.  */
--- libc/sysdeps/unix/sysv/linux/sigqueue.c.jj	Sat Oct 31 11:28:05 1998
+++ libc/sysdeps/unix/sysv/linux/sigqueue.c	Mon Jan 24 08:32:38 2000
@@ -1,4 +1,4 @@
-/* Copyright (C) 1997, 1998 Free Software Foundation, Inc.
+/* Copyright (C) 1997, 1998, 2000 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -19,6 +19,7 @@
 #include <errno.h>
 #include <signal.h>
 #include <unistd.h>
+#include <string.h>
 
 #include <sysdep.h>
 #include <sys/syscall.h>
@@ -35,9 +36,11 @@ __sigqueue (pid, sig, val)
 {
   siginfo_t info;
 
+  /* First, clear the siginfo_t structure, so that we don't pass our
+     stack content to other tasks.  */
+  memset (&info, 0, sizeof (siginfo_t));
   /* We must pass the information about the data in a siginfo_t value.  */
   info.si_signo = sig;
-  info.si_errno = 0;
   info.si_code = SI_QUEUE;
   info.si_pid = __getpid ();
   info.si_uid = __getuid ();
--- libc/sysdeps/unix/sysv/linux/aio_sigqueue.c.jj	Sun Aug 15 20:12:27 1999
+++ libc/sysdeps/unix/sysv/linux/aio_sigqueue.c	Mon Jan 24 08:34:46 2000
@@ -1,4 +1,4 @@
-/* Copyright (C) 1997, 1998, 1999 Free Software Foundation, Inc.
+/* Copyright (C) 1997, 1998, 1999, 2000 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -20,6 +20,7 @@
 #include <errno.h>
 #include <signal.h>
 #include <unistd.h>
+#include <string.h>
 
 #include <sysdep.h>
 #include <sys/syscall.h>
@@ -39,9 +40,11 @@ __aio_sigqueue (sig, val, caller_pid)
 {
   siginfo_t info;
 
+  /* First, clear the siginfo_t structure, so that we don't pass our
+     stack content to other tasks.  */
+  memset (&info, 0, sizeof (siginfo_t));
   /* We must pass the information about the data in a siginfo_t value.  */
   info.si_signo = sig;
-  info.si_errno = 0;
   info.si_code = SI_ASYNCIO;
   info.si_pid = caller_pid;
   info.si_uid = getuid ();


Cheers,
    Jakub
___________________________________________________________________
Jakub Jelinek | jakub@redhat.com | http://sunsite.mff.cuni.cz/~jj
Linux version 2.3.40 on a sparc64 machine (1343.49 BogoMips)
___________________________________________________________________

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Do we need Linux/alpha and Linux/sparc versions of <bits/siginfo.h>?
  2000-01-23 23:45 ` Jakub Jelinek
@ 2000-01-23 23:56   ` Andreas Jaeger
  2000-01-24  0:08     ` Jakub Jelinek
  0 siblings, 1 reply; 4+ messages in thread
From: Andreas Jaeger @ 2000-01-23 23:56 UTC (permalink / raw)
  To: Jakub Jelinek; +Cc: GNU libc hacker

>>>>> Jakub Jelinek writes:

 > On Mon, Jan 24, 2000 at 08:14:29AM +0100, Andreas Jaeger wrote:
>> 
>> Looking through the various asm-*/siginfo.h files in Linux 2.3.41pre2,
>> I've encountered only two platforms with problems: Alpha and Sparc.
>> Could the maintainers of these platforms please check the following
>> and take appropriate action?
>> 
>> Alpha defines:
>> #define SI_PAD_SIZE     ((SI_MAX_SIZE/sizeof(int)) - 4)
>> #define SIGEV_PAD_SIZE  ((SIGEV_MAX_SIZE/sizeof(int)) - 4)
>> 
>> but all other platforms have a 3 instead of a 4 for these two defines:
>> #define SI_PAD_SIZE     ((SI_MAX_SIZE/sizeof(int)) - 3)
>> #define SIGEV_PAD_SIZE  ((SIGEV_MAX_SIZE/sizeof(int)) - 3)
>> 
>> Sparc and Sparc64 additionally define the member _trapno for _sigfault
>> - and SIGEMT is also only used by Sparc*:
>> /* SIGILL, SIGFPE, SIGSEGV, SIGBUS, SIGEMT */
>> struct {
>> void *_addr;    /* faulting insn/memory ref. */
>> int  _trapno;   /* TRAP # which caused the signal */
>> } _sigfault;
>> 
>> 
>> Do we need Linux/alpha and Linux/sparc versions of <bits/siginfo.h>?

 > (Again, something which I had scheduled for today anyway).
Good that I didn't investigate more work into it;-).

Jakub, what do you think?  Are now (with your patch and Linux
2.3.41pre2) all siginfo problems fixed?  Is 32bit uid support complete
(apart from some cleaning up)?

 > IMHO, we need only separate version of sparc siginfo, plus use __WORDSIZE
 > in the generic linux version (I think ia64, ppc64, mips64 etc. could use it
 > as well):
MIPS has already a special version since some constants have different
values than the rest of the kernel :-(
 > [...]
New Sparc specific <bits/siginfo.h>:
 > +
 > +	/* SIGILL, SIGFPE, SIGSEGV, SIGBUS.  */
You didn't add SIGEMT in the comment - is this correct?
 > +	struct
 > +	  {
 > +	    void *si_addr;	/* Faulting insn/memory ref.  */
 > +	    int si_trapno;
 > +	  } _sigfault;

The rest looks fine.

Thanks,
Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.rhein-neckar.de

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Do we need Linux/alpha and Linux/sparc versions of <bits/siginfo.h>?
  2000-01-23 23:56   ` Andreas Jaeger
@ 2000-01-24  0:08     ` Jakub Jelinek
  0 siblings, 0 replies; 4+ messages in thread
From: Jakub Jelinek @ 2000-01-24  0:08 UTC (permalink / raw)
  To: Andreas Jaeger; +Cc: GNU libc hacker

> Jakub, what do you think?  Are now (with your patch and Linux
> 2.3.41pre2) all siginfo problems fixed?  Is 32bit uid support complete
> (apart from some cleaning up)?

If Linus eats my siginfo kernel patch (it clashes with your NSIGCHLD,
hopefully Linus will want to resolve that failed hunk), then hopefully
all should be ready, apart from a few missing kernel siginfo generation points.
Now the whole thing has to be heavily tested with 2.3 and 2.2 kernels.

> 
>  > IMHO, we need only separate version of sparc siginfo, plus use __WORDSIZE
>  > in the generic linux version (I think ia64, ppc64, mips64 etc. could use it
>  > as well):
> MIPS has already a special version since some constants have different
> values than the rest of the kernel :-(
>  > [...]
> New Sparc specific <bits/siginfo.h>:
>  > +
>  > +	/* SIGILL, SIGFPE, SIGSEGV, SIGBUS.  */
> You didn't add SIGEMT in the comment - is this correct?

Oopsie, you're right, should be there as well.
On the other side, the comments are pretty misleading in SIGCHLD and SIGPOLL
cases. Those structure layouts are for child deatch signal (which can be any
signal) and you can pass si_band/si_fd with signals other than SIGPOLL as
well.

Cheers,
    Jakub
___________________________________________________________________
Jakub Jelinek | jakub@redhat.com | http://sunsite.mff.cuni.cz/~jj
Linux version 2.3.40 on a sparc64 machine (1343.49 BogoMips)
___________________________________________________________________

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2000-01-24  0:08 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2000-01-23 23:15 Do we need Linux/alpha and Linux/sparc versions of <bits/siginfo.h>? Andreas Jaeger
2000-01-23 23:45 ` Jakub Jelinek
2000-01-23 23:56   ` Andreas Jaeger
2000-01-24  0:08     ` Jakub Jelinek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).