* TLS changes (broken tools warning)
@ 2002-08-01 20:32 Roland McGrath
2002-08-02 12:49 ` [PATCH] Fix isomac failure Jakub Jelinek
0 siblings, 1 reply; 6+ messages in thread
From: Roland McGrath @ 2002-08-01 20:32 UTC (permalink / raw)
To: GNU libc hackers
I have just checked in some changes to make libc use TLS internally when
__thread is available (along with some fixes to the TLS support code). All
available tools that claim to support TLS have bugs that will louse up your
libc build, so be sure to configure using --without-tls if you have tools
that claim to support TLS and __thread.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Fix isomac failure
2002-08-01 20:32 TLS changes (broken tools warning) Roland McGrath
@ 2002-08-02 12:49 ` Jakub Jelinek
2002-08-02 12:55 ` Roland McGrath
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jakub Jelinek @ 2002-08-02 12:49 UTC (permalink / raw)
To: Ulrich Drepper, Roland McGrath; +Cc: GNU libc hackers
On Thu, Aug 01, 2002 at 11:32:29PM -0400, Roland McGrath wrote:
> I have just checked in some changes to make libc use TLS internally when
> __thread is available (along with some fixes to the TLS support code). All
> available tools that claim to support TLS have bugs that will louse up your
> libc build, so be sure to configure using --without-tls if you have tools
> that claim to support TLS and __thread.
Even with --without-tls, this breaks make check - stdlib/isomac test fails
with:
Tested files:
assert.h
ctype.h
errno.h
#define BUSY_WAIT_NOP __asm__ ("rep; nop")
#define HAS_COMPARE_AND_SWAP
#define PT_EI extern inline
#define CURRENT_STACK_FRAME __builtin_frame_address (0)
float.h
iso646.h
limits.h
locale.h
math.h
setjmp.h
signal.h
stdarg.h
stddef.h
stdio.h
stdlib.h
string.h
time.h
wchar.h
wctype.h
In reality this is not a problem, since tls.h which brings all the above
stuff in is included in include/errno.h only, ie. private header.
The following patch should shut up make check:
2002-08-02 Jakub Jelinek <jakub@redhat.com>
* include/errno.h: Don't include tls.h if _ISOMAC is defined.
--- libc/include/errno.h.jj 2002-08-02 11:47:37.000000000 +0200
+++ libc/include/errno.h 2002-08-02 22:01:08.000000000 +0200
@@ -2,7 +2,7 @@
#include <stdlib/errno.h>
-#ifdef _ERRNO_H
+#if defined _ERRNO_H && !defined _ISOMAC
# include <tls.h> /* Defines USE_TLS. */
Jakub
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix isomac failure
2002-08-02 12:49 ` [PATCH] Fix isomac failure Jakub Jelinek
@ 2002-08-02 12:55 ` Roland McGrath
2002-08-02 12:59 ` Ulrich Drepper
2002-08-02 13:09 ` Roland McGrath
2 siblings, 0 replies; 6+ messages in thread
From: Roland McGrath @ 2002-08-02 12:55 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Ulrich Drepper, GNU libc hackers
Ah, I didn't notice this because isomac does not have proper dependencies
and so is not rebuilt when you change things. Why is isomac treated
strangely in stdlib/Makefile instead of being listed in tests?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix isomac failure
2002-08-02 12:49 ` [PATCH] Fix isomac failure Jakub Jelinek
2002-08-02 12:55 ` Roland McGrath
@ 2002-08-02 12:59 ` Ulrich Drepper
2002-08-02 13:09 ` Roland McGrath
2 siblings, 0 replies; 6+ messages in thread
From: Ulrich Drepper @ 2002-08-02 12:59 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Roland McGrath, GNU libc hackers
> 2002-08-02 Jakub Jelinek <jakub@redhat.com>
>
> * include/errno.h: Don't include tls.h if _ISOMAC is defined.
I've applied the patch. Thanks,
--
---------------. ,-. 1325 Chesapeake Terrace
Ulrich Drepper \ ,-------------------' \ Sunnyvale, CA 94089 USA
Red Hat `--' drepper at redhat.com `------------------------
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix isomac failure
2002-08-02 12:49 ` [PATCH] Fix isomac failure Jakub Jelinek
2002-08-02 12:55 ` Roland McGrath
2002-08-02 12:59 ` Ulrich Drepper
@ 2002-08-02 13:09 ` Roland McGrath
2002-08-02 13:32 ` Ulrich Drepper
2 siblings, 1 reply; 6+ messages in thread
From: Roland McGrath @ 2002-08-02 13:09 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Ulrich Drepper, GNU libc hackers
I tried running isomac with -I../include removed from its list of
switches to give the compiler, and it seemed to be happy.
Isn't this the right way to run it, with the public header files and no
libc-internal versions?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix isomac failure
2002-08-02 13:09 ` Roland McGrath
@ 2002-08-02 13:32 ` Ulrich Drepper
0 siblings, 0 replies; 6+ messages in thread
From: Ulrich Drepper @ 2002-08-02 13:32 UTC (permalink / raw)
To: Roland McGrath; +Cc: Jakub Jelinek, GNU libc hackers
Roland McGrath wrote:
> I tried running isomac with -I../include removed from its list of
> switches to give the compiler, and it seemed to be happy.
> Isn't this the right way to run it, with the public header files and no
> libc-internal versions?
No, we test the headers which will be installed without installing them.
This will pick up the internal headers but this cannot reasonably be
avoided.
--
---------------. ,-. 1325 Chesapeake Terrace
Ulrich Drepper \ ,-------------------' \ Sunnyvale, CA 94089 USA
Red Hat `--' drepper at redhat.com `------------------------
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2002-08-02 20:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-08-01 20:32 TLS changes (broken tools warning) Roland McGrath
2002-08-02 12:49 ` [PATCH] Fix isomac failure Jakub Jelinek
2002-08-02 12:55 ` Roland McGrath
2002-08-02 12:59 ` Ulrich Drepper
2002-08-02 13:09 ` Roland McGrath
2002-08-02 13:32 ` Ulrich Drepper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).