public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Andreas Jaeger <aj@suse.de>
Cc: Alexandre Oliva <aoliva@redhat.com>,
	GNU libc hacker <libc-hacker@sources.redhat.com>
Subject: Re: Fix _exit for Linux
Date: Mon, 16 Sep 2002 09:54:00 -0000	[thread overview]
Message-ID: <20020916185406.G1013@sunsite.ms.mff.cuni.cz> (raw)
In-Reply-To: <u8k7lm7wrv.fsf@gromit.moeb>; from aj@suse.de on Mon, Sep 16, 2002 at 05:57:08PM +0200

On Mon, Sep 16, 2002 at 05:57:08PM +0200, Andreas Jaeger wrote:
> Alexandre Oliva <aoliva@redhat.com> writes:
> 
> > On Sep 16, 2002, Andreas Jaeger <aj@suse.de> wrote:
> >
> >> +libc_hidden_def (_exit)
> >
> > Hmm.  I don't think this is right.  libc_hidden_proto (_exit) is
> > commented out in include/unistd.h, so, if my understanding is correct,
> 
> In that case it couldn't have worked before, have a look at
> sysdeps/unix/_exit.S, I just copied the declarations from there and
> that was the default used before AFAIK.

There is a difference between libc_hidden_def in .S files and in .c files.
In .S files it will work even if libc_hidden_proto () was not declared
in header files (usually the assembly doesn't even include those headers),
while if you use libc_hidden_{def,weak} without previous libc_hidden_proto,
things will break badly...

	Jakub

  parent reply	other threads:[~2002-09-16 16:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-15 20:40 Andreas Jaeger
2002-09-15 22:11 ` Ulrich Drepper
2002-09-15 23:56 ` Roland McGrath
2002-09-16  0:10   ` Ulrich Drepper
2002-09-16  0:36     ` Roland McGrath
2002-09-16  0:45       ` Ulrich Drepper
2002-09-16  9:46 ` Alexandre Oliva
2002-09-16  9:37   ` Andreas Jaeger
2002-09-16  9:52     ` Alexandre Oliva
2002-09-16  9:54     ` Jakub Jelinek [this message]
2002-09-16 10:14       ` Ulrich Drepper
2002-09-24 20:24         ` Alexandre Oliva
2002-09-24 20:28           ` Roland McGrath
2002-09-24 20:35             ` Ulrich Drepper
2002-09-24 21:08               ` Roland McGrath
2002-09-24 21:53                 ` Ulrich Drepper
2002-09-24 22:02                   ` Roland McGrath
2002-09-24 21:55                 ` Alexandre Oliva
2002-09-24 22:01                   ` Roland McGrath
2002-09-25 10:27               ` Andreas Jaeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020916185406.G1013@sunsite.ms.mff.cuni.cz \
    --to=jakub@redhat.com \
    --cc=aj@suse.de \
    --cc=aoliva@redhat.com \
    --cc=libc-hacker@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).