Re: Fix _exit for Linux

[Alexandre Oliva <aoliva@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 832 bytes --]

On Sep 16, 2002, Ulrich Drepper <drepper@redhat.com> wrote:

> Jakub Jelinek wrote:
>> There is a difference between libc_hidden_def in .S files and in .c files.
>> In .S files it will work even if libc_hidden_proto () was not declared
>> in header files (usually the assembly doesn't even include those headers),
>> while if you use libc_hidden_{def,weak} without previous libc_hidden_proto,
>> things will break badly...

> Anyway, the _exit code can now be hidden.  The implementation in glibc
> itself is now correct if compiled with the new kernel headers so there
> is no need to allow it to be overwritten.  Let's change
> include/unistd.h and add hidden everywhere for _exit.

Apologies for the delay.  Here's the patch that fixes the mips port
such that libc.so doesn't fail to link because __syscall_exit is not
defined.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: glibc-mips-_exit.patch --]
[-- Type: text/x-patch, Size: 834 bytes --]

Index: ChangeLog
from  Alexandre Oliva  <aoliva@redhat.com>

	* sysdeps/unix/sysv/linux/mips/syscalls.list: Added _exit.

Index: sysdeps/unix/sysv/linux/mips/syscalls.list
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/unix/sysv/linux/mips/syscalls.list,v
retrieving revision 1.32
diff -u -p -r1.32 syscalls.list
--- sysdeps/unix/sysv/linux/mips/syscalls.list 13 Sep 2002 07:12:28 -0000 1.32
+++ sysdeps/unix/sysv/linux/mips/syscalls.list 25 Sep 2002 03:23:27 -0000
@@ -82,3 +82,6 @@ sys_lstat	lxstat	lstat		i:sp	__syscall_l
 sys_readv	readv	readv		i:ipi	__syscall_readv
 sys_stat	xstat	stat		i:sp	__syscall_stat
 sys_writev	writev	writev		i:ipi	__syscall_writev
+
+# _exit() does INLINE_SYSCALL (_exit), but we don't have INLINE_SYSCALL
+sys_exit	_exit	exit		i:i	__syscall_exit

[-- Attachment #3: Type: text/plain, Size: 289 bytes --]


-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                 aoliva@{redhat.com, gcc.gnu.org}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist                Professional serial bug killer