From: Jakub Jelinek <jakub@redhat.com>
To: Roland McGrath <roland@redhat.com>
Cc: Ulrich Drepper <drepper@redhat.com>,
Glibc hackers <libc-hacker@sources.redhat.com>
Subject: Re: [PATCH] libc x86-64 __thread fix
Date: Mon, 14 Oct 2002 16:13:00 -0000 [thread overview]
Message-ID: <20021014230027.H3451@sunsite.ms.mff.cuni.cz> (raw)
In-Reply-To: <200210141937.g9EJbxx13170@magilla.sf.frob.com>; from roland@redhat.com on Mon, Oct 14, 2002 at 12:37:59PM -0700
On Mon, Oct 14, 2002 at 12:37:59PM -0700, Roland McGrath wrote:
> Something is wrong if you need that. USE___THREAD != HAVE___THREAD.
> Why is USE___THREAD defined in your rtld build?
Actually, maybe just the #include <tls.h> is needed.
The problem was that without including tls.h uname.os etc. in libc-pic.a
was calling __errno_location(), which caused rtld-errno-loc.os to be
added into librtld.a. But rtld-errno-loc.os would not compile, because
errno was first defined as normal variable in include/errno.h and then
redefined as __thread variable in sysdeps/generic/errno-loc.c.
Though IMHO putting RTLD_PRIVATE_ERRNO case before USE__THREAD
shouldn't hurt.
Jakub
next prev parent reply other threads:[~2002-10-14 21:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-14 12:38 Jakub Jelinek
2002-10-14 14:00 ` Roland McGrath
2002-10-14 16:13 ` Jakub Jelinek [this message]
2002-10-15 0:36 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021014230027.H3451@sunsite.ms.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).