[PATCH] pathconf and XFS/Reiserfs link count

[PATCH] pathconf and XFS/Reiserfs link count

[Thorsten Kukuk]

Hi,

the last patch for adding XFS link count was incomplete and for 
Alpha, the link count for Reiserfs was also missing. Here is a
patch with the missing parts:


2002-10-16  Thorsten Kukuk  <kukuk@suse.de>

	* sysdeps/unix/sysv/linux/pathconf.c: Add case for XFS link count.
	* sysdeps/unix/sysv/linux/alpha/pathconf.c: Add case for 
	XFS and REISERFS link count.

--- sysdeps/unix/sysv/linux/pathconf.c	6 Jul 2001 04:56:12 -0000	1.6
+++ sysdeps/unix/sysv/linux/pathconf.c	16 Oct 2002 09:02:23 -0000
@@ -82,6 +82,9 @@
 	case REISERFS_SUPER_MAGIC:
 	  return REISERFS_LINK_MAX;
 
+	case XFS_SUPER_MAGIC:
+	  return XFS_LINK_MAX;
+
 	default:
 	  return LINUX_LINK_MAX;
 	}
--- sysdeps/unix/sysv/linux/alpha/pathconf.c	6 Jul 2001 04:56:13 -0000	1.6
+++ sysdeps/unix/sysv/linux/alpha/pathconf.c	16 Oct 2002 09:02:23 -0000
@@ -86,6 +86,13 @@
 	case UFS_CIGAM:
 	  return UFS_LINK_MAX;
 
+	case REISERFS_SUPER_MAGIC:
+	  return REISERFS_LINK_MAX;
+
+	case XFS_SUPER_MAGIC:
+	  return XFS_LINK_MAX;
+
+
 	default:
 	  return LINUX_LINK_MAX;
 	}

-- 
Thorsten Kukuk       http://www.suse.de/~kukuk/        kukuk@suse.de
SuSE Linux AG        Deutschherrnstr. 15-19        D-90429 Nuernberg
--------------------------------------------------------------------    
Key fingerprint = A368 676B 5E1B 3E46 CFCE  2D97 F8FD 4E23 56C6 FB4B

Re: [PATCH] pathconf and XFS/Reiserfs link count

[Roland McGrath]

Thanks for the fix.  I was unhappy with the ugly situation that made this
so easy to miss, so I cleaned it up instead so that such changes now only
need to be made in one file.

Re: [PATCH] pathconf and XFS/Reiserfs link count

[Ulrich Drepper]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andi Kleen wrote:

> Just curious: why is it no option ?


Because libc wouldn't be self-contained.  That non-obvious file missing
could cause problems for the entire system.

- -- 
- --------------.                        ,-.            444 Castro Street
Ulrich Drepper \    ,-----------------'   \ Mountain View, CA 94041 USA
Red Hat         `--' drepper at redhat.com `---------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9rgYn2ijCOnn/RHQRAk5fAJ0b50PxLLtAKTKfmrgXVkCurry/DgCgysfu
89czPKF1Dg1NBMt9JiW+5RE=
=QAQP
-----END PGP SIGNATURE-----

Re: [PATCH] pathconf and XFS/Reiserfs link count

[Ulrich Drepper]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Roland McGrath wrote:

> I think the current situation is utterly disgusting.  The only thing that
> makes any kind of sense to me is direct kernel support, and I can't fathom
> why it wasn't done that way a long time ago.


I' pleading for kernel sysconf, pathcond, and fpathconf support for
years but nobody listens.  Until then we have no choice but to use the
current sources since using an external file is no option.

- -- 
- --------------.                        ,-.            444 Castro Street
Ulrich Drepper \    ,-----------------'   \ Mountain View, CA 94041 USA
Red Hat         `--' drepper at redhat.com `---------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9rgJM2ijCOnn/RHQRAszCAJ9K/lsxdOBmNpvn+dWETRUV6LHFrwCfXGhs
YBo66WXn/RIuBSGow4s4H+0=
=D0Sx
-----END PGP SIGNATURE-----

Re: [PATCH] pathconf and XFS/Reiserfs link count

[Roland McGrath]

> How about moving the list to a file in /etc ? 

Someone would have to maintain that too.

> The current version doesn't even cover all file systems included in
> linux 2.4 that support hardlinks and for each new file system it'll need a 
> new patch too. And linux has plenty of new file systems in development.

I think the current situation is utterly disgusting.  The only thing that
makes any kind of sense to me is direct kernel support, and I can't fathom
why it wasn't done that way a long time ago.