From: Thorsten Kukuk <kukuk@suse.de>
To: Ulrich Drepper <drepper@redhat.com>
Cc: libc-hacker@sources.redhat.com
Subject: Re: bits/libc-lock.h and _LIBC
Date: Mon, 04 Nov 2002 01:32:00 -0000 [thread overview]
Message-ID: <20021104103253.A20309@suse.de> (raw)
In-Reply-To: <3DC63DEA.7020101@redhat.com>
On Mon, Nov 04, Ulrich Drepper wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Thorsten Kukuk wrote:
>
> > We install libc-lock.h into /usr/include/bits. But libc-lock.h is
> > only useable, if it is compiled with -D_LIBC, which breaks now with
> > libio.h.
>
> What exactly fails? And when did it change? The header is in this form
> installed on my systems and I have no problems using <libio.h>.
The nss_db package, for example.
libio.h uses some glibc internal things like attribute hidden, if
_LIBC is defined, but without _LIBC defined, bits/libc-lock.h use
useless.
> > I suggest the following patch, or is there any reason for the
> > ifdef _LIBC around __libc_lock_t ? We don't do this for __libc_key_t
> > and all the other definitions.
>
> I've made the types opaque back when for a good reason. I think it was
> mainly the use in libstdc++ but also to prevent any kind of initializers.
Than do it for all or for nothing. If you currently wish to use
libc-lock.h, you need to define _LIBC, but if you do this, you
cannot include something, which includes libio.h, afterwards.
The current bits/libc-lock.h behavior is inconsistent.
Thorsten
--
Thorsten Kukuk http://www.suse.de/~kukuk/ kukuk@suse.de
SuSE Linux AG Deutschherrnstr. 15-19 D-90429 Nuernberg
--------------------------------------------------------------------
Key fingerprint = A368 676B 5E1B 3E46 CFCE 2D97 F8FD 4E23 56C6 FB4B
next prev parent reply other threads:[~2002-11-04 9:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-22 6:51 Thorsten Kukuk
2002-11-04 1:29 ` Ulrich Drepper
2002-11-04 1:32 ` Thorsten Kukuk [this message]
2002-11-04 1:46 ` Ulrich Drepper
2002-11-08 9:57 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021104103253.A20309@suse.de \
--to=kukuk@suse.de \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).