From: Jakub Jelinek <jakub@redhat.com>
To: Roland McGrath <roland@redhat.com>, Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix non-IA32 build
Date: Tue, 10 Dec 2002 10:02:00 -0000 [thread overview]
Message-ID: <20021210190249.N1310@sunsite.ms.mff.cuni.cz> (raw)
Hi!
Some __libc aliases were missing on various arches.
I'm not sure if it is a good idea to export the new
pthread wrappers @@GLIBC_2.3.1, because that will mean current programs/libs
won't use the wrapped syscalls. IMHO it would be much better to export
them at the versions they have in libc.so. select would be a slight problem,
since it is usually select@@GLIBC_2.0, but on Alpha it is
select@@GLIBC_2.1.
2002-12-10 Jakub Jelinek <jakub@redhat.com>
* include/libc-symbols.h: Fix a comment typo.
* sysdeps/unix/sysv/linux/alpha/select.S (__libc_select): New alias.
* sysdeps/unix/sysv/linux/alpha/sigsuspend.S (__libc_sigsuspend):
Likewise.
* sysdeps/unix/sysv/linux/ia64/sigsuspend.c (__libc_sigsuspend):
Likewise.
* sysdeps/unix/sysv/linux/s390/s390-64/sigsuspend.c
(__libc_sigsuspend): Likewise.
* sysdeps/unix/sysv/linux/sparc/sparc64/sigsuspend.c
(__libc_sigsuspend): Likewise.
* sysdeps/generic/creat.c (__libc_creat): Renamed from creat.
(creat): New weak alias.
--- libc/include/libc-symbols.h.jj 2002-11-05 23:10:07.000000000 +0100
+++ libc/include/libc-symbols.h 2002-12-10 17:36:24.000000000 +0100
@@ -655,7 +655,7 @@
There is no reason to use hidden_weak over hidden_def in assembly,
but we provide it for consistency with the C usage.
hidden_proto doesn't make sense for assembly but the equivalent
- is to call via the HIDDEN_JUMPTARGET macro einstead of JUMPTARGET. */
+ is to call via the HIDDEN_JUMPTARGET macro instead of JUMPTARGET. */
# define hidden_def(name) strong_alias (name, __GI_##name)
# define hidden_weak(name) hidden_def (name)
# define hidden_ver(local, name) strong_alias (local, __GI_##name)
--- libc/sysdeps/unix/sysv/linux/alpha/select.S.jj 2002-11-08 11:39:46.000000000 +0100
+++ libc/sysdeps/unix/sysv/linux/alpha/select.S 2002-12-10 17:31:49.000000000 +0100
@@ -125,7 +125,9 @@ default_symbol_version (__select_tv64, _
strong_alias (__select_tv64, __select_tv64p)
default_symbol_version (__select_tv64p, select, GLIBC_2.1)
libc_hidden_ver (__select_tv64, __select)
+strong_alias (__select_tv64, __libc_select)
#else
+strong_alias (__select, __libc_select)
weak_alias (__select, select)
libc_hidden_def (__select)
#endif
--- libc/sysdeps/unix/sysv/linux/alpha/sigsuspend.S.jj 2002-11-08 11:39:46.000000000 +0100
+++ libc/sysdeps/unix/sysv/linux/alpha/sigsuspend.S 2002-12-10 17:34:10.000000000 +0100
@@ -53,3 +53,4 @@ error:
libc_hidden_def (__sigsuspend)
weak_alias(__sigsuspend, sigsuspend)
+strong_alias (__sigsuspend, __libc_sigsuspend)
--- libc/sysdeps/unix/sysv/linux/ia64/sigsuspend.c.jj 2002-08-03 11:09:56.000000000 +0200
+++ libc/sysdeps/unix/sysv/linux/ia64/sigsuspend.c 2002-12-10 17:37:21.000000000 +0100
@@ -39,3 +39,4 @@ __sigsuspend (set)
}
libc_hidden_def (__sigsuspend)
weak_alias (__sigsuspend, sigsuspend)
+strong_alias (__sigsuspend, __libc_sigsuspend)
--- libc/sysdeps/unix/sysv/linux/s390/s390-64/sigsuspend.c.jj 2002-08-03 11:09:58.000000000 +0200
+++ libc/sysdeps/unix/sysv/linux/s390/s390-64/sigsuspend.c 2002-12-10 17:37:52.000000000 +0100
@@ -38,3 +38,4 @@ __sigsuspend (set)
}
libc_hidden_def (__sigsuspend)
weak_alias (__sigsuspend, sigsuspend)
+strong_alias (__sigsuspend, __libc_sigsuspend)
--- libc/sysdeps/unix/sysv/linux/sparc/sparc64/sigsuspend.c.jj 2002-08-03 11:09:59.000000000 +0200
+++ libc/sysdeps/unix/sysv/linux/sparc/sparc64/sigsuspend.c 2002-12-10 17:38:24.000000000 +0100
@@ -38,3 +38,4 @@ __sigsuspend (set)
}
libc_hidden_def (__sigsuspend)
weak_alias (__sigsuspend, sigsuspend)
+strong_alias (__sigsuspend, __libc_sigsuspend)
--- libc/sysdeps/generic/creat.c.jj 2001-08-23 18:49:27.000000000 +0200
+++ libc/sysdeps/generic/creat.c 2002-12-10 18:09:16.000000000 +0100
@@ -23,9 +23,10 @@
/* Create FILE with protections MODE. */
int
-creat (file, mode)
+__libc_creat (file, mode)
const char *file;
mode_t mode;
{
return __open (file, O_WRONLY|O_CREAT|O_TRUNC, mode);
}
+weak_alias (__libc_creat, creat)
Jakub
next reply other threads:[~2002-12-10 18:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-10 10:02 Jakub Jelinek [this message]
2002-12-10 12:23 ` Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021210190249.N1310@sunsite.ms.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).