* [PATCH] Fix linuxthreads and nptl builds
@ 2003-01-02 12:51 Jakub Jelinek
0 siblings, 0 replies; only message in thread
From: Jakub Jelinek @ 2003-01-02 12:51 UTC (permalink / raw)
To: Ulrich Drepper, Roland McGrath; +Cc: Glibc hackers
Hi!
After __register_atfork has been made libc_hidden_*, the tree
is broken, since libpthread_nonshared.a contains undefined reference
to __GI___register_atfork (and this gets linked into librt.so too,
so librt is broken as well).
As pthread_atfork is not in the makefile part of any library routines
which would get special NOT_IN_libc IS_IN_something, it is compiled
as if it were part of libc.so, which is wrong.
2003-01-02 Jakub Jelinek <jakub@redhat.com>
linuxthreads/
* Makefile (CFLAGS-pthread_atfork.c): Add -DNOT_IN_libc.
nptl/
* Makefile (CFLAGS-pthread_atfork.c): Add -DNOT_IN_libc.
--- libc/linuxthreads/Makefile.jj 2002-12-31 11:46:37.000000000 +0100
+++ libc/linuxthreads/Makefile 2003-01-02 15:11:19.000000000 +0100
@@ -1,4 +1,4 @@
-# Copyright (C) 1996-2001, 2002 Free Software Foundation, Inc.
+# Copyright (C) 1996-2002, 2003 Free Software Foundation, Inc.
# This file is part of the GNU C Library.
# The GNU C Library is free software; you can redistribute it and/or
@@ -54,6 +54,8 @@ libpthread-shared-only-routines = pt-all
libpthread-nonshared = pthread_atfork
+CFLAGS-pthread_atfork.c = -DNOT_IN_libc
+
nodelete-yes = -Wl,--enable-new-dtags,-z,nodelete
initfirst-yes = -Wl,--enable-new-dtags,-z,initfirst
LDFLAGS-pthread.so = $(nodelete-$(have-z-nodelete)) \
--- libc/nptl/Makefile.jj 2003-01-02 11:30:43.000000000 +0100
+++ libc/nptl/Makefile 2003-01-02 15:10:55.000000000 +0100
@@ -1,4 +1,4 @@
-# Copyright (C) 2002 Free Software Foundation, Inc.
+# Copyright (C) 2002, 2003 Free Software Foundation, Inc.
# This file is part of the GNU C Library.
# The GNU C Library is free software; you can redistribute it and/or
@@ -113,6 +113,8 @@ libpthread-shared-only-routines = pt-all
libpthread-nonshared = pthread_atfork
+CFLAGS-pthread_atfork.c = -DNOT_IN_libc
+
# Don't generate deps for calls with no sources. See sysdeps/unix/Makefile.
omit-deps = $(unix-syscalls:%=ptw-%)
Jakub
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-01-02 12:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-01-02 12:51 [PATCH] Fix linuxthreads and nptl builds Jakub Jelinek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).