* small patch for arm sysdep
@ 2003-03-27 0:26 Philip Blundell
2003-03-27 2:46 ` Roland McGrath
0 siblings, 1 reply; 2+ messages in thread
From: Philip Blundell @ 2003-03-27 0:26 UTC (permalink / raw)
To: libc-hacker
The existing definition for PSEUDO_RET_NOERRNO isn't quite correct.
"movcc" is a predicated instruction; it only returns if the carry flag
is clear. What's needed here is an unconditional return.
p.
2003-03-27 Philip Blundell <philb@gnu.org>
* sysdeps/unix/sysv/linux/arm/sysdep.h (PSEUDO_RET_NOERRNO): Use
unconditional mov. Remove nop.
Index: sysdeps/unix/sysv/linux/arm/sysdep.h
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/unix/sysv/linux/arm/sysdep.h,v
retrieving revision 1.23
diff -u -r1.23 sysdep.h
--- sysdeps/unix/sysv/linux/arm/sysdep.h 24 Mar 2003 19:00:28 -0000 1.23
+++ sysdeps/unix/sysv/linux/arm/sysdep.h 27 Mar 2003 00:17:34 -0000
@@ -71,8 +71,8 @@
DO_CALL (syscall_name, args);
#define PSEUDO_RET_NOERRNO \
- RETINSTR(movcc, pc, lr); \
- nop
+ RETINSTR(mov, pc, lr);
+
#undef ret_NOERRNO
#define ret_NOERRNO PSEUDO_RET_NOERRNO
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: small patch for arm sysdep
2003-03-27 0:26 small patch for arm sysdep Philip Blundell
@ 2003-03-27 2:46 ` Roland McGrath
0 siblings, 0 replies; 2+ messages in thread
From: Roland McGrath @ 2003-03-27 2:46 UTC (permalink / raw)
To: Philip Blundell; +Cc: libc-hacker
Thanks, I put these in.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-03-27 2:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-03-27 0:26 small patch for arm sysdep Philip Blundell
2003-03-27 2:46 ` Roland McGrath
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).