public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Fix linuxthreads when spawned from programs using NPTL
@ 2003-04-03 14:03 Jakub Jelinek
  2003-04-03 18:55 ` Ulrich Drepper
  0 siblings, 1 reply; 3+ messages in thread
From: Jakub Jelinek @ 2003-04-03 14:03 UTC (permalink / raw)
  To: Ulrich Drepper, Roland McGrath; +Cc: Glibc hackers

Hi!

If a linuxthreads programs is spawned from a threaded NPTL program
(such as gnome-terminal, konsole etc.), bad things happen as
since 2003-03-25 NPTL blocks __SIGRTMIN+1, so all LT threads
but the manager (which does SIG_SETMASK at the very end) never receive
__pthread_sig_cancel.

2003-04-03  Jakub Jelinek  <jakub@redhat.com>

	* pthread.c (pthread_initialize): Unblock __pthread_sig_cancel
	in case the parent blocked it.

--- linuxthreads/pthread.c.jj	2003-04-03 07:16:43.000000000 -0500
+++ linuxthreads/pthread.c	2003-04-03 08:38:29.000000000 -0500
@@ -550,6 +550,10 @@ static void pthread_initialize(void)
   sigemptyset(&mask);
   sigaddset(&mask, __pthread_sig_restart);
   sigprocmask(SIG_BLOCK, &mask, NULL);
+  /* And unblock __pthread_sig_cancel if it has been blocked. */
+  sigdelset(&mask, __pthread_sig_restart);
+  sigaddset(&mask, __pthread_sig_cancel);
+  sigprocmask(SIG_UNBLOCK, &mask, NULL);
   /* Register an exit function to kill all other threads. */
   /* Do it early so that user-registered atexit functions are called
      before pthread_*exit_process. */

	Jakub

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix linuxthreads when spawned from programs using NPTL
  2003-04-03 14:03 [PATCH] Fix linuxthreads when spawned from programs using NPTL Jakub Jelinek
@ 2003-04-03 18:55 ` Ulrich Drepper
  2003-04-03 20:16   ` Roland McGrath
  0 siblings, 1 reply; 3+ messages in thread
From: Ulrich Drepper @ 2003-04-03 18:55 UTC (permalink / raw)
  To: Jakub Jelinek; +Cc: Roland McGrath, Glibc hackers

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jakub Jelinek wrote:

> If a linuxthreads programs is spawned from a threaded NPTL program
> (such as gnome-terminal, konsole etc.), bad things happen as
> since 2003-03-25 NPTL blocks 

This problem existed forever, why nobody noticed it is a big question.
Applied.  Thanks,

- -- 
- --------------.                        ,-.            444 Castro Street
Ulrich Drepper \    ,-----------------'   \ Mountain View, CA 94041 USA
Red Hat         `--' drepper at redhat.com `---------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+jIOE2ijCOnn/RHQRAjW5AKCWz/DtYzfdS/KeCCUGq5E4VpI9oQCeOKdv
SDKU+EoUvc3BpysEimKGpW8=
=x1+z
-----END PGP SIGNATURE-----

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix linuxthreads when spawned from programs using NPTL
  2003-04-03 18:55 ` Ulrich Drepper
@ 2003-04-03 20:16   ` Roland McGrath
  0 siblings, 0 replies; 3+ messages in thread
From: Roland McGrath @ 2003-04-03 20:16 UTC (permalink / raw)
  To: Ulrich Drepper; +Cc: Jakub Jelinek, Glibc hackers

It seems to me that NPTL should not leave signals blocked when it execs.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2003-04-03 20:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-04-03 14:03 [PATCH] Fix linuxthreads when spawned from programs using NPTL Jakub Jelinek
2003-04-03 18:55 ` Ulrich Drepper
2003-04-03 20:16   ` Roland McGrath

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).