public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] s390* pthread_spin_unlock.
@ 2003-04-11 15:46 Martin Schwidefsky
  2003-04-11 22:06 ` Roland McGrath
  0 siblings, 1 reply; 2+ messages in thread
From: Martin Schwidefsky @ 2003-04-11 15:46 UTC (permalink / raw)
  To: libc-hacker

Hi,
this is one of those "how could this ever work" bugs. The pthread_spin_lock
primitive in linuxthread for s390* is broken. The following patch fixes it.

blue skies,
  Martin.

2003-04-11  Martin Schwidefsky  <schwidefsky@de.ibm.com>

	* sysdeps/s390/pspinlock.c (__pthread_spin_unlock): Fix asm contraints.

diff -urN libc/linuxthreads/sysdeps/s390/pspinlock.c libc-s390/linuxthreads/sysdeps/s390/pspinlock.c
--- libc/linuxthreads/sysdeps/s390/pspinlock.c	Fri Apr 11 17:34:17 2003
+++ libc-s390/linuxthreads/sysdeps/s390/pspinlock.c	Fri Apr 11 17:33:22 2003
@@ -64,7 +64,7 @@
 {
   asm volatile("    xc 0(4,%0),0(%0)\n"
 	       "    bcr 15,0"
-	       : "=a" (lock) );
+	       : : "a" (lock) : "memory" );
   return 0;
 }
 weak_alias (__pthread_spin_unlock, pthread_spin_unlock)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] s390* pthread_spin_unlock.
  2003-04-11 15:46 [PATCH] s390* pthread_spin_unlock Martin Schwidefsky
@ 2003-04-11 22:06 ` Roland McGrath
  0 siblings, 0 replies; 2+ messages in thread
From: Roland McGrath @ 2003-04-11 22:06 UTC (permalink / raw)
  To: Martin Schwidefsky; +Cc: libc-hacker

> Hi,
> this is one of those "how could this ever work" bugs. The pthread_spin_lock
> primitive in linuxthread for s390* is broken. The following patch fixes it.

I put your fix in.


Thanks,
Roland

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-04-11 22:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-04-11 15:46 [PATCH] s390* pthread_spin_unlock Martin Schwidefsky
2003-04-11 22:06 ` Roland McGrath

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).