* Incomplete dependencies for libio/old*.c
@ 2003-04-27 16:11 Andreas Schwab
2003-04-27 18:35 ` Roland McGrath
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Schwab @ 2003-04-27 16:11 UTC (permalink / raw)
To: libc-hacker
Dependencies are generated using the non-pic command line (ie. without
-DSHARED). This is a problem with some of the compatibility sources
which check SHLIB_COMPAT before including the headers, so that the
generated dependency list is incomplete.
Andreas.
2003-04-27 Andreas Schwab <schwab@suse.de>
* Makeconfig (+mkdep): Add -DMAKING_DEPENDENCIES.
* include/shlib-compat.h (SHLIB_COMPAT) [MAKING_DEPENDENCIES]:
Define to 1.
--- Makeconfig.~1.282.~ 2003-04-16 23:05:35.000000000 +0200
+++ Makeconfig 2003-04-27 14:21:24.000000000 +0200
@@ -557,7 +557,7 @@ endif
# The -MP flag tells GCC >= 3.2 (which we now require) to produce dummy
# targets for headers so that removed headers don't break the build.
ifndef +mkdep
-+mkdep = $(CC) -M -MP
++mkdep = $(CC) -DMAKING_DEPENDENCIES -M -MP
endif
# The program that makes Emacs-style TAGS files.
--- include/shlib-compat.h.~1.10.~ 2002-10-14 11:06:09.000000000 +0200
+++ include/shlib-compat.h 2003-04-27 14:23:50.000000000 +0200
@@ -26,7 +26,12 @@
#include <abi-versions.h> /* header generated by abi-versions.awk */
#endif
-#if defined HAVE_ELF && defined SHARED && defined DO_VERSIONING
+#ifdef MAKING_DEPENDENCIES
+
+/* While computing dependencies we want to see all headers. */
+# define SHLIB_COMPAT(lib, introduced, obsoleted) 1
+
+#elif defined HAVE_ELF && defined SHARED && defined DO_VERSIONING
/* The file abi-versions.h (generated by scripts/abi-versions.awk) defines
symbols like `ABI_libm_GLIBC_2_0' for each version set in the source
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Incomplete dependencies for libio/old*.c
2003-04-27 16:11 Incomplete dependencies for libio/old*.c Andreas Schwab
@ 2003-04-27 18:35 ` Roland McGrath
0 siblings, 0 replies; 2+ messages in thread
From: Roland McGrath @ 2003-04-27 18:35 UTC (permalink / raw)
To: Andreas Schwab; +Cc: libc-hacker
This is a band-aid that still doesn't guarantee the results will be correct
in all cases. Instead, we should try out the idea of using -MD output
with separate .d files for each object flavor.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-04-27 18:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-04-27 16:11 Incomplete dependencies for libio/old*.c Andreas Schwab
2003-04-27 18:35 ` Roland McGrath
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).