glibc cvs on sparc32 (_dl_hwcap error)

glibc cvs on sparc32 (_dl_hwcap error)

[Thorsten Kukuk]

Hi,

On sparc32 I now get the following error with current glibc cvs:

gcc -m32 dl-support.c -c -std=gnu99 -O2 -Wall -Winline -Wstrict-prototypes -Wwrite-strings -fcall-used-g6 -g -m32 -mtune=ultrasparc      -I../include -I.
+-I/usr/src/packages/BUILD/glibc-2.3/cc/elf -I.. -I../libio  -I/usr/src/packages/BUILD/glibc-2.3/cc -I../sysdeps/sparc/sparc32/elf -I../linuxthreads/sysdeps/unix/sysv/linux/sparc/sparc32
+-I../linuxthreads/sysdeps/unix/sysv/linux/sparc -I../linuxthreads/sysdeps/unix/sysv/linux -I../linuxthreads/sysdeps/pthread -I../sysdeps/pthread -I../linuxthreads/sysdeps/unix/sysv
+-I../linuxthreads/sysdeps/unix -I../linuxthreads/sysdeps/sparc/sparc32 -I../linuxthreads/sysdeps/sparc -I../sysdeps/unix/sysv/linux/sparc/sparc32 -I../sysdeps/unix/sysv/linux/sparc
+-I../sysdeps/unix/sysv/linux -I../sysdeps/gnu -I../sysdeps/unix/common -I../sysdeps/unix/mman -I../sysdeps/unix/inet -I../sysdeps/unix/sysv -I../sysdeps/unix/sparc -I../sysdeps/unix
+-I../sysdeps/posix -I../sysdeps/sparc/sparc32/fpu -I../sysdeps/sparc/sparc32 -I../sysdeps/wordsize-32 -I..
 /sysdeps/ieee754/flt-32 -I../sysdeps/ieee754/dbl-64 -I../sysdeps/sparc/sparc32/soft-fp -I../sysdeps/sparc/fpu -I../sysdeps/sparc -I../sysdeps/ieee754 -I../sysdeps/generic/elf
+-I../sysdeps/generic -nostdinc -isystem /usr/lib/gcc-lib/sparc-suse-linux/3.3/include -isystem /usr/src/packages/BUILD/kernel-headers -D_LIBC_REENTRANT -include ../include/libc-symbols.h
+-o /usr/src/packages/BUILD/glibc-2.3/cc/elf/dl-support.o -MD -MP -MF /usr/src/packages/BUILD/glibc-2.3/cc/elf/dl-support.o.dt
../sysdeps/sparc/sparc32/dl-machine.h:365: warning: inlining failed in call to `sparc_fixup_plt'
../sysdeps/sparc/sparc32/dl-machine.h:417: warning: called from here
/tmp/ccCHIq7h.s: Assembler messages:
/tmp/ccCHIq7h.s:6139: Error: symbol `_dl_hwcap' can not be both weak and common
make[2]: *** [/usr/src/packages/BUILD/glibc-2.3/cc/elf/dl-support.o] Error 1
make[2]: Leaving directory `/usr/src/packages/BUILD/glibc-2.3/elf'
make[1]: *** [elf/subdir_lib] Error 2
make[1]: Leaving directory `/usr/src/packages/BUILD/glibc-2.3'
make: *** [all] Error 2

  Thorsten
-- 
Thorsten Kukuk       http://www.suse.de/~kukuk/        kukuk@suse.de
SuSE Linux AG        Deutschherrnstr. 15-19        D-90429 Nuernberg
--------------------------------------------------------------------    
Key fingerprint = A368 676B 5E1B 3E46 CFCE  2D97 F8FD 4E23 56C6 FB4B

[PATCH] Fix glibc cvs on sparc32 (_dl_hwcap error)

[Jakub Jelinek]

On Fri, Jul 25, 2003 at 01:07:30PM +0200, Thorsten Kukuk wrote:
> On sparc32 I now get the following error with current glibc cvs:
> /tmp/ccCHIq7h.s:6139: Error: symbol `_dl_hwcap' can not be both weak and common

Does the following fix it?

2003-07-25  Jakub Jelinek  <jakub@redhat.com>

	* elf/dl-support.c (_dl_hwcap): Add nocommon attribute.

--- libc/elf/dl-support.c.jj	2003-07-23 03:56:17.000000000 -0400
+++ libc/elf/dl-support.c	2003-07-25 07:10:48.000000000 -0400
@@ -123,7 +123,7 @@ int _dl_correct_cache_id = _DL_CACHE_DEF
 
 struct ElfW(Phdr) *_dl_phdr;
 size_t _dl_phnum;
-unsigned long int _dl_hwcap;
+unsigned long int _dl_hwcap __attribute__((nocommon));
 
 #ifdef NEED_DL_SYSINFO
 /* Needed for improved syscall handling on at least x86/Linux.  */


	Jakub

Re: [PATCH] Fix glibc cvs on sparc32 (_dl_hwcap error)

[Thorsten Kukuk]

On Fri, Jul 25, Jakub Jelinek wrote:

> On Fri, Jul 25, 2003 at 01:07:30PM +0200, Thorsten Kukuk wrote:
> > On sparc32 I now get the following error with current glibc cvs:
> > /tmp/ccCHIq7h.s:6139: Error: symbol `_dl_hwcap' can not be both weak and common
> 
> Does the following fix it?

Yes, thanks, but now "make check" fails with:

tst-tlsmod14a.c:11: error: thread-local storage not supported for this target

-- 
Thorsten Kukuk       http://www.suse.de/~kukuk/        kukuk@suse.de
SuSE Linux AG        Deutschherrnstr. 15-19        D-90429 Nuernberg
--------------------------------------------------------------------    
Key fingerprint = A368 676B 5E1B 3E46 CFCE  2D97 F8FD 4E23 56C6 FB4B