public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
* alpha pwrite patch
@ 2003-07-29 19:59 Philip Blundell
  2003-07-29 20:05 ` Jakub Jelinek
  0 siblings, 1 reply; 2+ messages in thread
From: Philip Blundell @ 2003-07-29 19:59 UTC (permalink / raw)
  To: libc-hacker

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

I needed this patch to compile on Alpha, otherwise I was seeing
undefined references to __GI___pwrite64.  Alpha doesn't declare
__NR_pread64 or __NR_pwrite64, so these lines in syscalls.list were
previously ignored and the generic sysdeps/unix/sysv/linux/pwrite.c was
used instead.

p.


[-- Attachment #2: pwrite.diff --]
[-- Type: text/plain, Size: 1044 bytes --]

2003-07-29  Philip Blundell  <philb@gnu.org>

	* sysdeps/unix/sysv/linux/alpha/syscalls.list (pread): Syscall
	name is pread, not pread64.
	(pwrite): Likewise vs pwrite64.

--- sysdeps/unix/sysv/linux/alpha/syscalls.list	24 Jun 2003 16:26:34 -0000	1.59
+++ sysdeps/unix/sysv/linux/alpha/syscalls.list	29 Jul 2003 19:23:02 -0000
@@ -22,8 +22,8 @@
 llseek		EXTRA	lseek		C:3	__libc_lseek	__lseek lseek __libc_lseek64 __llseek llseek __lseek64 lseek64
 lseek		llseek	-
 posix_fadvise64	-	fadvise64	4	posix_fadvise64	posix_fadvise
-pread		-	pread64		C:4	__libc_pread	__libc_pread64 __pread pread __pread64 pread64
-pwrite		-	pwrite64		C:4	__libc_pwrite	__libc_pwrite64 __pwrite pwrite __pwrite64 pwrite64
+pread		-	pread		C:4	__libc_pread	__libc_pread64 __pread pread __pread64 pread64
+pwrite		-	pwrite		C:4	__libc_pwrite	__libc_pwrite64 __pwrite pwrite __pwrite64 pwrite64
 fstatfs		-	fstatfs		i:ip	__fstatfs	fstatfs __fstatfs64 fstatfs64
 statfs		-	statfs		i:sp	__statfs	statfs statfs64
 getrlimit	-	getrlimit	2	__getrlimit	getrlimit getrlimit64

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: alpha pwrite patch
  2003-07-29 19:59 alpha pwrite patch Philip Blundell
@ 2003-07-29 20:05 ` Jakub Jelinek
  0 siblings, 0 replies; 2+ messages in thread
From: Jakub Jelinek @ 2003-07-29 20:05 UTC (permalink / raw)
  To: Philip Blundell; +Cc: libc-hacker

On Tue, Jul 29, 2003 at 08:59:18PM +0100, Philip Blundell wrote:
> I needed this patch to compile on Alpha, otherwise I was seeing
> undefined references to __GI___pwrite64.  Alpha doesn't declare
> __NR_pread64 or __NR_pwrite64, so these lines in syscalls.list were
> previously ignored and the generic sysdeps/unix/sysv/linux/pwrite.c was
> used instead.

Alpha does declare them (e.g. 2.6.0-test2):
#define __NR_pread64                    349
#define __NR_pwrite64                   350

This means you should do something similar to
e.g. sysdeps/unix/sysv/linux/powerpc/powerpc64/sysdep.h
(either exactly what ppc64 does plus your patch below, or
replace pread64/pwrite64 with pread/pwrite and vice versa
and you don't need syscalls.list change).

> 2003-07-29  Philip Blundell  <philb@gnu.org>
> 
> 	* sysdeps/unix/sysv/linux/alpha/syscalls.list (pread): Syscall
> 	name is pread, not pread64.
> 	(pwrite): Likewise vs pwrite64.
> 
> --- sysdeps/unix/sysv/linux/alpha/syscalls.list	24 Jun 2003 16:26:34 -0000	1.59
> +++ sysdeps/unix/sysv/linux/alpha/syscalls.list	29 Jul 2003 19:23:02 -0000
> @@ -22,8 +22,8 @@
>  llseek		EXTRA	lseek		C:3	__libc_lseek	__lseek lseek __libc_lseek64 __llseek llseek __lseek64 lseek64
>  lseek		llseek	-
>  posix_fadvise64	-	fadvise64	4	posix_fadvise64	posix_fadvise
> -pread		-	pread64		C:4	__libc_pread	__libc_pread64 __pread pread __pread64 pread64
> -pwrite		-	pwrite64		C:4	__libc_pwrite	__libc_pwrite64 __pwrite pwrite __pwrite64 pwrite64
> +pread		-	pread		C:4	__libc_pread	__libc_pread64 __pread pread __pread64 pread64
> +pwrite		-	pwrite		C:4	__libc_pwrite	__libc_pwrite64 __pwrite pwrite __pwrite64 pwrite64
>  fstatfs		-	fstatfs		i:ip	__fstatfs	fstatfs __fstatfs64 fstatfs64
>  statfs		-	statfs		i:sp	__statfs	statfs statfs64
>  getrlimit	-	getrlimit	2	__getrlimit	getrlimit getrlimit64


	Jakub

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-07-29 20:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-07-29 19:59 alpha pwrite patch Philip Blundell
2003-07-29 20:05 ` Jakub Jelinek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).