[PATCH] Fix PRs glibc/{93,94,98,107}

[PATCH] Fix PRs glibc/{93,94,98,107}

[Jakub Jelinek]

Hi!

Selected obvious fixes from glibc bugzilla.

2004-04-21  Jakub Jelinek  <jakub@redhat.com>

	* posix/tst-chmod.c (do_test): Fix a typo.
	* elf/lateglobal.c (main): Fix error checks.
	Patch by Stephen Clarke <stephen.clarke@st.com>.

	* manual/ctype.texi (isblank, iswblank): Mark as ISO functions,
	mention they have been added in ISO C99.
	* manual/summary.texi: Rebuilt.
	Reported by Ben Pfaff <blp@cs.stanford.edu>.

2004-03-31  H.J. Lu  <hongjiu.lu@intel.com>

	* sysdeps/ieee754/ldbl-128/bits/huge_vall.h: Fix typo.

--- libc/posix/tst-chmod.c.jj	2001-07-06 06:55:38.000000000 +0200
+++ libc/posix/tst-chmod.c	2004-04-21 11:05:05.269228742 +0200
@@ -1,5 +1,5 @@
 /* Test for chmod functions.
-   Copyright (C) 2000 Free Software Foundation, Inc.
+   Copyright (C) 2000, 2004 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
    Contributed by Ulrich Drepper <drepper@cygnus.com>, 2000.
 
@@ -72,7 +72,7 @@ do_test (int argc, char *argv[])
   buf = (char *) alloca (buflen);
 
   /* Create the directory name.  */
-  snprintf (buf, buflen, "%schmoddirXXXXXX", builddir);
+  snprintf (buf, buflen, "%s/chmoddirXXXXXX", builddir);
 
   if (mkdtemp (buf) == NULL)
     {
--- libc/elf/lateglobal.c.jj	2000-10-21 09:13:32.000000000 +0200
+++ libc/elf/lateglobal.c	2004-04-21 11:07:13.840187153 +0200
@@ -13,14 +13,14 @@ main (void)
   mtrace ();
 
   h[0] = dlopen ("ltglobmod1.so", RTLD_LAZY);
-  if (h == NULL)
+  if (h[0] == NULL)
     {
       printf ("%s: cannot open %s: %s",
 	      __FUNCTION__, "ltglobmod1.so", dlerror ());
       exit (EXIT_FAILURE);
     }
   h[1] = dlopen ("ltglobmod2.so", RTLD_LAZY);
-  if (h == NULL)
+  if (h[1] == NULL)
     {
       printf ("%s: cannot open %s: %s",
 	      __FUNCTION__, "ltglobmod2.so", dlerror ());
--- libc/sysdeps/ieee754/ldbl-128/bits/huge_vall.h.jj	2004-03-15 22:44:10.000000000 +0100
+++ libc/sysdeps/ieee754/ldbl-128/bits/huge_vall.h	2004-04-21 11:01:30.391737586 +0200
@@ -45,7 +45,7 @@ typedef union { unsigned char __c[16]; l
 #  define HUGE_VALL	(__extension__ \
 			 ((__huge_vall_t) { __c : __HUGE_VALL_bytes }).__ld)
 # else
-static __huge_val_t __huge_val = { __HUGE_VAL_bytes };
-#  define HUGE_VALL	(__huge_val.__d)
+static __huge_vall_t __huge_vall = { __HUGE_VALL_bytes };
+#  define HUGE_VALL	(__huge_vall.__ld)
 # endif
 #endif 
--- libc/manual/summary.texi.jj	2003-11-12 00:41:09.000000000 +0100
+++ libc/manual/summary.texi	2004-04-21 10:49:24.701790673 +0200
@@ -4957,7 +4957,7 @@
 @comment isblank
 @item int isblank (int @var{c})
 
-@file{ctype.h} (GNU):  @ref{Classification of Characters}.
+@file{ctype.h} (ISO):  @ref{Classification of Characters}.
 
 @comment iscntrl
 @item int iscntrl (int @var{c})
@@ -5102,7 +5102,7 @@
 @comment iswblank
 @item int iswblank (wint_t @var{wc})
 
-@file{wctype.h} (GNU):  @ref{Classification of Wide Characters}.
+@file{wctype.h} (ISO):  @ref{Classification of Wide Characters}.
 
 @comment iswcntrl
 @item int iswcntrl (wint_t @var{wc})
--- libc/manual/ctype.texi.jj	2002-06-30 05:35:20.000000000 +0200
+++ libc/manual/ctype.texi	2004-04-21 10:43:50.947603769 +0200
@@ -159,10 +159,10 @@ vertical tab
 
 @cindex blank character
 @comment ctype.h
-@comment GNU
+@comment ISO
 @deftypefun int isblank (int @var{c})
 Returns true if @var{c} is a blank character; that is, a space or a tab.
-This function is a GNU extension.
+This function has been added in @w{ISO C99}.
 @end deftypefun
 
 @cindex graphic character
@@ -595,10 +595,11 @@ characters as well.
 
 @cindex blank character
 @comment wctype.h
-@comment GNU
+@comment ISO
 @deftypefun int iswblank (wint_t @var{wc})
 Returns true if @var{wc} is a blank character; that is, a space or a tab.
-This function is a GNU extension.  It is declared in @file{wchar.h}.
+This function has been added in @w{ISO C99}.  It is declared in
+@file{wchar.h}.
 @end deftypefun
 
 @node Using Wide Char Classes, Wide Character Case Conversion, Classification of Wide Characters, Character Handling

	Jakub

Re: [PATCH] Fix PRs glibc/{93,94,98,107}

[Ulrich Drepper]

Applied.

-- 
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖

Re: [PATCH] Fix PRs glibc/{93,94,98,107}

[Roland McGrath]

> Selected obvious fixes from glibc bugzilla.

I think we should start a convention for mentioning bug #s in log entries.
Some rigid format that regexps can match easily.  I think we can then set
something up so the commits with matching entries automagically add
comments to bugzilla.

> 2004-04-21  Jakub Jelinek  <jakub@redhat.com>
> 
> 	* posix/tst-chmod.c (do_test): Fix a typo.
> 	* elf/lateglobal.c (main): Fix error checks.
> 	Patch by Stephen Clarke <stephen.clarke@st.com>.

These are separate, a blank line should be between them.

> 	* manual/ctype.texi (isblank, iswblank): Mark as ISO functions,
> 	mention they have been added in ISO C99.

I've changed these to say that these were originally GNU extensions.

> 	* manual/summary.texi: Rebuilt.
> 	Reported by Ben Pfaff <blp@cs.stanford.edu>.

This generated file is not in CVS at all.

> 2004-03-31  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	* sysdeps/ieee754/ldbl-128/bits/huge_vall.h: Fix typo.

I've put all these in with the changes mentioned.

Re: [PATCH] Fix PRs glibc/{93,94,98,107}

[Petter Reinholdtsen]

[Roland McGrath]
>> Selected obvious fixes from glibc bugzilla.
> I think we should start a convention for mentioning bug #s in log
> entries.  Some rigid format that regexps can match easily.

I agree.  Ulrich used "[BZ #19]" in a changelog entry, so I used the
same format.

> I think we can then set something up so the commits with matching
> entries automagically add comments to bugzilla.

That would be very good. :)