* [PATCH] Avoid pthread_exit in librt.so.1
@ 2004-08-11 12:56 Jakub Jelinek
2004-08-11 18:51 ` Roland McGrath
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2004-08-11 12:56 UTC (permalink / raw)
To: Ulrich Drepper; +Cc: Glibc hackers
Hi!
Its a little hard to preach how costly pthread_exit (NULL); at the very end
of a thread main routine is compared to return NULL when glibc itself uses
it too...
2004-08-11 Jakub Jelinek <jakub@redhat.com>
* sysdeps/pthread/aio_misc.c (handle_fildes_io): Remove noreturn
attribute. Return NULL instead of calling pthread_exit at the end.
--- libc/sysdeps/pthread/aio_misc.c.jj 2004-05-26 16:05:31.000000000 +0200
+++ libc/sysdeps/pthread/aio_misc.c 2004-08-11 14:51:49.358696666 +0200
@@ -1,5 +1,6 @@
/* Handle general operations.
- Copyright (C) 1997,1998,1999,2000,2001,2003 Free Software Foundation, Inc.
+ Copyright (C) 1997, 1998, 1999, 2000, 2001, 2003, 2004
+ Free Software Foundation, Inc.
This file is part of the GNU C Library.
Contributed by Ulrich Drepper <drepper@cygnus.com>, 1997.
@@ -470,7 +471,6 @@ __aio_enqueue_request (aiocb_union *aioc
static void *
-__attribute__ ((noreturn))
handle_fildes_io (void *arg)
{
pthread_t self = pthread_self ();
@@ -676,7 +676,7 @@ handle_fildes_io (void *arg)
}
while (runp != NULL);
- pthread_exit (NULL);
+ return NULL;
}
Jakub
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Avoid pthread_exit in librt.so.1
2004-08-11 12:56 [PATCH] Avoid pthread_exit in librt.so.1 Jakub Jelinek
@ 2004-08-11 18:51 ` Roland McGrath
0 siblings, 0 replies; 2+ messages in thread
From: Roland McGrath @ 2004-08-11 18:51 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Ulrich Drepper, Glibc hackers
> 2004-08-11 Jakub Jelinek <jakub@redhat.com>
>
> * sysdeps/pthread/aio_misc.c (handle_fildes_io): Remove noreturn
> attribute. Return NULL instead of calling pthread_exit at the end.
Applied.
Thanks,
Roland
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-08-11 18:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-08-11 12:56 [PATCH] Avoid pthread_exit in librt.so.1 Jakub Jelinek
2004-08-11 18:51 ` Roland McGrath
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).