From: Andreas Jaeger <aj@suse.de>
To: libc-hacker@sources.redhat.com
Subject: Re: Fix locale/weight.h with GCC 3.5
Date: Mon, 06 Sep 2004 19:22:00 -0000 [thread overview]
Message-ID: <200409062122.50418.aj@suse.de> (raw)
In-Reply-To: <200409062051.48190.aj@suse.de>
[-- Attachment #1: Type: text/plain, Size: 1873 bytes --]
On Monday 06 September 2004 20:51, Andreas Jaeger wrote:
> Compiling glibc with GCC 3.5 I got the following failure:
>
> In file included from strcoll_l.c:87:
> ../locale/weight.h: In function `__strcoll_l':
> ../locale/weight.h:24: error: invalid storage class for function `findidx'
> make[2]: *** [/builds/glibc/3.5/string/strcoll_l.o] Error 1
> make[2]: Leaving directory `/cvs/libc/string'
>
> Since we include weight.h in block scope, we have to remove the static to
> make it work with GCC 3.5 (see
> http://gcc.gnu.org/ml/gcc-patches/2004-08/msg02641.html). There are some
> more places that fail similiar.
>
> Ok to commit the appended patch?
>
> There're some more places like this - expect a followup-email tomorrow,
This is a mess - if I change elf/dynamic-link.h in a similar way (see below)
I finally get:
/builds/glibc/3.5/elf/dl-load.os(.text+0x0): In function
`elf_get_dynamic_info':
/cvs/libc/elf/dynamic-link.h:70: multiple definition of `elf_get_dynamic_info'
/builds/glibc/3.5/elf/rtld.os(.text+0x40):/cvs/libc/elf/dynamic-link.h:70:
firstdefined here
Any ideas?
Andreas
============================================================
Index: elf/dynamic-link.h
--- elf/dynamic-link.h 6 Mar 2004 09:47:17 -0000 1.50
+++ elf/dynamic-link.h 6 Sep 2004 19:22:03 -0000
@@ -65,7 +65,7 @@ elf_machine_lazy_rel (struct link_map *m
/* Read the dynamic section at DYN and fill in INFO with indices DT_*. */
-static inline void __attribute__ ((unused, always_inline))
+inline void __attribute__ ((unused, always_inline))
elf_get_dynamic_info (struct link_map *l, ElfW(Dyn) *temp)
{
ElfW(Dyn) *dyn = l->l_ld;
--
Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
SUSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-09-06 19:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-06 18:52 Andreas Jaeger
2004-09-06 19:22 ` Andreas Jaeger [this message]
2004-09-06 21:21 ` Roland McGrath
2004-09-07 5:06 ` Andreas Jaeger
2004-09-07 8:02 ` Roland McGrath
2004-09-07 11:26 ` Andreas Jaeger
2004-09-07 18:09 ` Andreas Jaeger
2004-09-07 21:26 ` Roland McGrath
2004-09-08 4:57 ` Andreas Jaeger
2004-09-08 5:40 ` Andreas Jaeger
2004-09-08 17:01 ` Roland McGrath
2004-09-08 17:24 ` Andreas Jaeger
2004-09-08 17:46 ` Roland McGrath
2004-09-08 19:33 ` Andreas Jaeger
2004-09-08 19:44 ` Andreas Jaeger
2004-09-08 20:02 ` Roland McGrath
2004-09-09 8:19 ` Jakub Jelinek
2004-09-09 9:20 ` Andreas Jaeger
2004-09-21 7:19 ` Andreas Jaeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200409062122.50418.aj@suse.de \
--to=aj@suse.de \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).