From: Andreas Jaeger <aj@suse.de>
To: libc-hacker@sources.redhat.com
Cc: Roland McGrath <roland@redhat.com>
Subject: Re: Fix locale/weight.h with GCC 3.5
Date: Wed, 08 Sep 2004 19:44:00 -0000 [thread overview]
Message-ID: <200409082144.33512.aj@suse.de> (raw)
In-Reply-To: <hor7pck72m.fsf@reger.suse.de>
[-- Attachment #1: Type: text/plain, Size: 2252 bytes --]
On Wednesday 08 September 2004 19:24, Andreas Jaeger wrote:
> Roland McGrath <roland@redhat.com> writes:
> >> -static inline void
> >> +inline void
> >> +__attribute ((always_inline))
> >> elf_machine_rela (struct link_map *map, const Elf64_Rela *reloc,
> >> const Elf64_Sym *sym, const struct r_found_version *version,
> >> void *const reloc_addr_arg)
> >
> > Does this really do the right thing in all of 3.[345]?
> > I would think this would generate an external entry point too.
>
> It seems so :-(
>
> $ nm dl-conflict.os
> U _dl_argv_internal
> U _dl_dprintf
> U _dl_reloc_bad_type
> 00000000000000a0 T _dl_resolve_conflicts
> 0000000000000000 t elf_machine_rela.0
> U _GLOBAL_OFFSET_TABLE_
> 0000000000000017 r .LC0
> 0000000000000000 r .LC1
> 0000000000000000 r .LC2
> U _rtld_local
> U _rtld_local_ro
>
> So, should I add #ifndef RESOLVE here also?
Wait - this seems to be produced even with the current glibc without my
changes (glibc compiled by GCC 3.3):
nm /lib64/ld-linux-x86-64.so.2 |grep elf_machine_rela
0000000000000d40 t elf_machine_rela.0
0000000000007fa0 t elf_machine_rela.0
000000000000d010 t elf_machine_rela.0
0000000000000d70 t elf_machine_rela_relative.1
0000000000008330 t elf_machine_rela_relative.1
For reference, compile:
int
test (int j)
{
static inline int
__attribute__ ((always_inline))
test_inline (int i)
{
return i++;
}
return test_inline (j);
}
I get with GCC 3.3:
gromit:/tmp:[0]$ gcc -Wall -c t.c -O2
gromit:/tmp:[0]$ nm t.o
0000000000000010 T test
0000000000000000 t test_inline.0
But with 3.4 (and also 3.5 removing the static):
gromit:/tmp:[0]$ /opt/gcc/3.4-devel/bin/gcc -Wall -c t.c -O2
gromit:/tmp:[0]$ nm t.o
0000000000000000 T test
It's a local entry point in 3.3.
The local entry point exists for me with both 3.3 and 3.5 in dl-reloc.o.
I guess we should go with my patch. Ok?
Andreas
--
Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
SUSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-09-08 19:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-06 18:52 Andreas Jaeger
2004-09-06 19:22 ` Andreas Jaeger
2004-09-06 21:21 ` Roland McGrath
2004-09-07 5:06 ` Andreas Jaeger
2004-09-07 8:02 ` Roland McGrath
2004-09-07 11:26 ` Andreas Jaeger
2004-09-07 18:09 ` Andreas Jaeger
2004-09-07 21:26 ` Roland McGrath
2004-09-08 4:57 ` Andreas Jaeger
2004-09-08 5:40 ` Andreas Jaeger
2004-09-08 17:01 ` Roland McGrath
2004-09-08 17:24 ` Andreas Jaeger
2004-09-08 17:46 ` Roland McGrath
2004-09-08 19:33 ` Andreas Jaeger
2004-09-08 19:44 ` Andreas Jaeger [this message]
2004-09-08 20:02 ` Roland McGrath
2004-09-09 8:19 ` Jakub Jelinek
2004-09-09 9:20 ` Andreas Jaeger
2004-09-21 7:19 ` Andreas Jaeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200409082144.33512.aj@suse.de \
--to=aj@suse.de \
--cc=libc-hacker@sources.redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).