public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Ulrich Drepper <drepper@redhat.com>,
	Glibc hackers <libc-hacker@sources.redhat.com>
Subject: Re: [PATCH] Add multiple inclusion guards to useldt.h
Date: Sat, 25 Sep 2004 10:07:00 -0000	[thread overview]
Message-ID: <200409251006.i8PA6uoX012150@magilla.sf.frob.com> (raw)
In-Reply-To: Jakub Jelinek's message of  Saturday, 25 September 2004 10:10:40 +0200 <20040925081040.GR30497@sunsite.ms.mff.cuni.cz>

> >From reading the code, I believe i686 --with-tls linuxthreads
> are now broken.

Ack!  You're right.  The report was about i586 being broken, and I tested
that and failed to go back and test the i686 build.  It's even worse than
you thought, though!  useldt.h gets included once before USE_TLS is set and
once after, changing how it defines things.  So plain multiple inclusion
protection would in fact break it.  I put in another tweak and now I think
both builds are ok again.


Thanks,
Roland

  reply	other threads:[~2004-09-25 10:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-25  8:11 Jakub Jelinek
2004-09-25 10:07 ` Roland McGrath [this message]
2004-10-01  8:33 ` Thorsten Kukuk
2004-10-01  8:38   ` Jakub Jelinek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200409251006.i8PA6uoX012150@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=drepper@redhat.com \
    --cc=jakub@redhat.com \
    --cc=libc-hacker@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).