public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
* Fix install-headers to install <bits/stdio_lim.h>
@ 2004-09-26 21:03 Andreas Schwab
  2004-09-26 21:30 ` Roland McGrath
  2004-09-26 21:31 ` Roland McGrath
  0 siblings, 2 replies; 5+ messages in thread
From: Andreas Schwab @ 2004-09-26 21:03 UTC (permalink / raw)
  To: libc-hacker

Running make install-headers should also install <bits/stdio_lim.h>, this
is needed when bootstrapping the toolchain.

Andreas.

2004-09-26  Andreas Schwab  <schwab@suse.de>

	* stdio-common/Makefile (headers): Add bits/stdio_lim.h.
	(install-others): Don't define.
	($(inst_includedir)/bits/stdio_lim.h): Remove rule.

Index: stdio-common/Makefile
===================================================================
RCS file: /cvs/glibc/libc/stdio-common/Makefile,v
retrieving revision 1.90
diff -u -p -a -u -p -a -r1.90 stdio-common/Makefile
--- stdio-common/Makefile	10 Aug 2004 18:01:29 -0000	1.90
+++ stdio-common/Makefile	26 Sep 2004 19:54:08 -0000
@@ -21,7 +21,7 @@
 #
 subdir	:= stdio-common
 
-headers	:= printf.h stdio_ext.h
+headers	:= printf.h stdio_ext.h bits/stdio_lim.h
 
 routines	:=							      \
 	ctermid cuserid							      \
@@ -36,8 +36,6 @@ routines	:=							      \
 	remove rename							      \
 	flockfile ftrylockfile funlockfile
 
-install-others = $(inst_includedir)/bits/stdio_lim.h
-
 include ../Makeconfig
 
 aux	:= errlist siglist printf-parsemb printf-parsewc
@@ -59,9 +57,6 @@ test-srcs = tst-unbputc tst-printf
 
 include ../Rules
 
-$(inst_includedir)/bits/stdio_lim.h: $(common-objpfx)bits/stdio_lim.h $(+force)
-	$(do-install)
-
 ifeq ($(cross-compiling),no)
 .PHONY: do-tst-unbputc do-tst-printf
 tests: do-tst-unbputc do-tst-printf

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Fix install-headers to install <bits/stdio_lim.h>
  2004-09-26 21:03 Fix install-headers to install <bits/stdio_lim.h> Andreas Schwab
@ 2004-09-26 21:30 ` Roland McGrath
  2004-09-26 21:37   ` Andreas Schwab
  2004-09-26 21:31 ` Roland McGrath
  1 sibling, 1 reply; 5+ messages in thread
From: Roland McGrath @ 2004-09-26 21:30 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: libc-hacker

> Running make install-headers should also install <bits/stdio_lim.h>, this
> is needed when bootstrapping the toolchain.

headers is usually used for source files.  I think adding to it may break
some other rules that assume that.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Fix install-headers to install <bits/stdio_lim.h>
  2004-09-26 21:03 Fix install-headers to install <bits/stdio_lim.h> Andreas Schwab
  2004-09-26 21:30 ` Roland McGrath
@ 2004-09-26 21:31 ` Roland McGrath
  1 sibling, 0 replies; 5+ messages in thread
From: Roland McGrath @ 2004-09-26 21:31 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: libc-hacker

You might just try adding a install-headers-nosubdir dep.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Fix install-headers to install <bits/stdio_lim.h>
  2004-09-26 21:30 ` Roland McGrath
@ 2004-09-26 21:37   ` Andreas Schwab
  2004-09-26 21:59     ` Roland McGrath
  0 siblings, 1 reply; 5+ messages in thread
From: Andreas Schwab @ 2004-09-26 21:37 UTC (permalink / raw)
  To: Roland McGrath; +Cc: libc-hacker

Roland McGrath <roland@redhat.com> writes:

>> Running make install-headers should also install <bits/stdio_lim.h>, this
>> is needed when bootstrapping the toolchain.
>
> headers is usually used for source files.  I think adding to it may break
> some other rules that assume that.

We already add generated files via sysdep_headers.  The only thing that
may break is make dist, but we don't support that any longer anyway.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Fix install-headers to install <bits/stdio_lim.h>
  2004-09-26 21:37   ` Andreas Schwab
@ 2004-09-26 21:59     ` Roland McGrath
  0 siblings, 0 replies; 5+ messages in thread
From: Roland McGrath @ 2004-09-26 21:59 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: libc-hacker

> We already add generated files via sysdep_headers.  The only thing that
> may break is make dist, but we don't support that any longer anyway.

Ok, then your change is fine.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2004-09-26 21:59 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-09-26 21:03 Fix install-headers to install <bits/stdio_lim.h> Andreas Schwab
2004-09-26 21:30 ` Roland McGrath
2004-09-26 21:37   ` Andreas Schwab
2004-09-26 21:59     ` Roland McGrath
2004-09-26 21:31 ` Roland McGrath

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).