public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Andreas Jaeger <aj@suse.de>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: Re: Fixes for make clean
Date: Fri, 07 Jan 2005 12:44:00 -0000	[thread overview]
Message-ID: <20050107124425.GB17169@sunsite.mff.cuni.cz> (raw)
In-Reply-To: <m3sm5ibwe5.fsf@gromit.moeb>

On Mon, Jan 03, 2005 at 12:10:58PM +0100, Andreas Jaeger wrote:
> 2005-01-03  Andreas Jaeger  <aj@suse.de>
> 
> 	* elf/Makefile (tests): Change rule for tst-pie1 so that make
> 	clean works.
> 
> --- elf/Makefile	27 Oct 2004 20:26:47 -0000	1.287
> +++ elf/Makefile	3 Jan 2005 11:10:36 -0000
> @@ -1,4 +1,4 @@
> -# Copyright (C) 1995-2002, 2003, 2004 Free Software Foundation, Inc.
> +# Copyright (C) 1995-2004, 2005 Free Software Foundation, Inc.
>  # This file is part of the GNU C Library.
>  
>  # The GNU C Library is free software; you can redistribute it and/or
> @@ -163,7 +163,7 @@ tests-nodlopen-yes = nodlopen nodlopen2
>  tests-execstack-yes = tst-execstack tst-execstack-needed tst-execstack-prog
>  endif
>  ifeq (yesyes,$(have-fpie)$(build-shared))
> -tests: $(objpfx)tst-pie1.out
> +tests += tst-pie1
>  endif
>  modules-names = testobj1 testobj2 testobj3 testobj4 testobj5 testobj6 \
>  		testobj1_1 failobj constload2 constload3 unloadmod \

This change is bad:
make[2]: Entering directory
`/usr/src/build/502950-i686/BUILD/glibc-20050106T2203/elf' Makefile:726: warning: overriding commands for target `/usr/src/build/502950-i686/BUILD/glibc-20050106T2203/build-i686-linux/elf/tst-pie1'
../Rules:118: warning: ignoring old commands for target `/usr/src/build/502950-i686/BUILD/glibc-20050106T2203/build-i686-linux/elf/tst-pie1'
mkdir /usr/src/build/502950-i686/BUILD/glibc-20050106T2203/build-i686-linux/elf

I think putting tst-pie1.out and tst-pie1 into generated instead would cure
this.

	Jakub

  parent reply	other threads:[~2005-01-07 12:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-03 11:11 Andreas Jaeger
2005-01-03 16:57 ` Ulrich Drepper
2005-01-07 12:44 ` Jakub Jelinek [this message]
2005-01-07 13:58   ` Andreas Jaeger
2005-01-08 16:39     ` [PATCH] Fixes for make clean (take 2) Jakub Jelinek
2005-01-08 16:49       ` Andreas Jaeger
2005-01-08 17:04         ` Jakub Jelinek
2005-01-08 17:13           ` Andreas Jaeger
  -- strict thread matches above, loose matches on Subject: below --
2003-12-31 11:34 Fixes for make clean Andreas Jaeger
2003-12-31 22:52 ` Roland McGrath
2003-05-05 11:14 Andreas Jaeger
2003-05-05 17:20 ` Ulrich Drepper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050107124425.GB17169@sunsite.mff.cuni.cz \
    --to=jakub@redhat.com \
    --cc=aj@suse.de \
    --cc=libc-hacker@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).