* sysdeps/generic changes
@ 2005-12-22 1:15 Roland McGrath
2005-12-23 4:49 ` Steven Munroe
0 siblings, 1 reply; 3+ messages in thread
From: Roland McGrath @ 2005-12-22 1:15 UTC (permalink / raw)
To: GNU libc hacker
I tried to do a somewhat exhaustive change of #include "" to <> in cases
where it might have been wrong. I left many "" cases that were clearly
right or clearly didn't matter, though I also changed some that didn't
really matter. Hopefully I changed all the ones that matter and didn't
change any that shouldn't have been changed.
After this it's probably possible to move header files from sysdeps/generic
into respective subdirs for headers that are only referenced within their
own subdir (the top-level subdir whose Makefile lists that header).
Similarly, nptl/sysdeps/{pthread,generic} files that are only used in the
libpthread build can move to nptl/.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: sysdeps/generic changes
2005-12-22 1:15 sysdeps/generic changes Roland McGrath
@ 2005-12-23 4:49 ` Steven Munroe
2005-12-23 5:10 ` Roland McGrath
0 siblings, 1 reply; 3+ messages in thread
From: Steven Munroe @ 2005-12-23 4:49 UTC (permalink / raw)
To: Roland McGrath; +Cc: GNU libc hacker
[-- Attachment #1: Type: text/plain, Size: 1376 bytes --]
Roland McGrath wrote:
>I tried to do a somewhat exhaustive change of #include "" to <> in cases
>where it might have been wrong. I left many "" cases that were clearly
>right or clearly didn't matter, though I also changed some that didn't
>really matter. Hopefully I changed all the ones that matter and didn't
>change any that shouldn't have been changed.
>
>After this it's probably possible to move header files from sysdeps/generic
>into respective subdirs for headers that are only referenced within their
>own subdir (the top-level subdir whose Makefile lists that header).
>Similarly, nptl/sysdeps/{pthread,generic} files that are only used in the
>libpthread build can move to nptl/.
>
>
>
The latest changes are causing a build breaks. The first problem is with
the tricky include recussion in nptl/sysdeps/pthread/sigaction.c. With
the new directory structure it is getting the ENOSYS stub instead of the
__libc_sigaction from sysdeps/unix/sysv/linux. This seems to be problem
for any arch that does not have a arch specific sigaction down the
sysdeps/unix/sysv/linux path (powerpc being an example).
Placing a include stub in sysdeps/unix/sysv/linux/powerpc/sigaction.c is
an effective work around.
There also seems to be a problem with the declaration of
__libc_cleanup_routine in libc-lock.h (at least with gcc-3.4) still
looking at this one ...
[-- Attachment #2: ppc-sigaction-20051222.txt --]
[-- Type: text/plain, Size: 477 bytes --]
2005-12-12 Steven Munroe <sjmunroe@us.ibm.com>
* sysdeps/unix/sysv/linux/powerpc/sigaction.c: New file.
diff -urN libc24-cvstip-20051222/sysdeps/unix/sysv/linux/powerpc/sigaction.c libc24/sysdeps/unix/sysv/linux/powerpc/sigaction.c
--- libc24-cvstip-20051222/sysdeps/unix/sysv/linux/powerpc/sigaction.c Wed Dec 31 18:00:00 1969
+++ libc24/sysdeps/unix/sysv/linux/powerpc/sigaction.c Thu Dec 22 17:26:37 2005
@@ -0,0 +1,1 @@
+#include <sysdeps/unix/sysv/linux/sigaction.c>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: sysdeps/generic changes
2005-12-23 4:49 ` Steven Munroe
@ 2005-12-23 5:10 ` Roland McGrath
0 siblings, 0 replies; 3+ messages in thread
From: Roland McGrath @ 2005-12-23 5:10 UTC (permalink / raw)
To: Steven Munroe; +Cc: GNU libc hacker
I've checked in a better fix. That is a real subtle situation using
#include_next, and I don't think we have others susceptible to quite the
same issue. But folks should be on the lookout for include file orders that
changed.
Thanks,
Roland
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-12-23 5:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-12-22 1:15 sysdeps/generic changes Roland McGrath
2005-12-23 4:49 ` Steven Munroe
2005-12-23 5:10 ` Roland McGrath
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).