public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
* [PATCH]: Fix Sparc errlist-compat
@ 2005-12-27  3:51 David S. Miller
  2005-12-27  8:53 ` Jakub Jelinek
  0 siblings, 1 reply; 6+ messages in thread
From: David S. Miller @ 2005-12-27  3:51 UTC (permalink / raw)
  To: libc-hacker


With the robust futex errnos added in current 2.6.x kernel
headers, the Sparc errlist-compat needs to be bumped up to
134.

Please apply, thanks.

2005-12-26  David S. Miller  <davem@sunset.davemloft.net>

	* sysdeps/unix/sysv/linux/sparc/Versions: Bump errlist-compat up
	to 134 for GLIBC_2.3

Index: sysdeps/unix/sysv/linux/sparc/Versions
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/unix/sysv/linux/sparc/Versions,v
retrieving revision 1.1
diff -u -r1.1 Versions
--- sysdeps/unix/sysv/linux/sparc/Versions	28 Aug 2002 23:56:02 -0000	1.1
+++ sysdeps/unix/sysv/linux/sparc/Versions	27 Dec 2005 03:48:47 -0000
@@ -13,7 +13,7 @@
     _sys_errlist; sys_errlist; _sys_nerr; sys_nerr;
   }
   GLIBC_2.3 {
-    #errlist-compat	128
+    #errlist-compat	134
     _sys_errlist; sys_errlist; _sys_nerr; sys_nerr;
   }
 }

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH]: Fix Sparc errlist-compat
  2005-12-27  3:51 [PATCH]: Fix Sparc errlist-compat David S. Miller
@ 2005-12-27  8:53 ` Jakub Jelinek
  2005-12-27  9:10   ` David S. Miller
  0 siblings, 1 reply; 6+ messages in thread
From: Jakub Jelinek @ 2005-12-27  8:53 UTC (permalink / raw)
  To: David S. Miller; +Cc: libc-hacker

On Mon, Dec 26, 2005 at 07:51:31PM -0800, David S. Miller wrote:
> 
> With the robust futex errnos added in current 2.6.x kernel
> headers, the Sparc errlist-compat needs to be bumped up to
> 134.
> 
> Please apply, thanks.

This is ABI incompatible change, which really can't be done this way.
If more error values are needed, they should be added at
GLIBC_2.4 (likely not just on SPARC but on other arches as well).

> 2005-12-26  David S. Miller  <davem@sunset.davemloft.net>
> 
> 	* sysdeps/unix/sysv/linux/sparc/Versions: Bump errlist-compat up
> 	to 134 for GLIBC_2.3
> 
> --- sysdeps/unix/sysv/linux/sparc/Versions	28 Aug 2002 23:56:02 -0000	1.1
> +++ sysdeps/unix/sysv/linux/sparc/Versions	27 Dec 2005 03:48:47 -0000
> @@ -13,7 +13,7 @@
>      _sys_errlist; sys_errlist; _sys_nerr; sys_nerr;
>    }
>    GLIBC_2.3 {
> -    #errlist-compat	128
> +    #errlist-compat	134
>      _sys_errlist; sys_errlist; _sys_nerr; sys_nerr;
>    }
>  }

	Jakub

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH]: Fix Sparc errlist-compat
  2005-12-27  8:53 ` Jakub Jelinek
@ 2005-12-27  9:10   ` David S. Miller
  2005-12-27 15:03     ` Ulrich Drepper
  0 siblings, 1 reply; 6+ messages in thread
From: David S. Miller @ 2005-12-27  9:10 UTC (permalink / raw)
  To: jakub; +Cc: libc-hacker

From: Jakub Jelinek <jakub@redhat.com>
Date: Tue, 27 Dec 2005 09:53:14 +0100

> This is ABI incompatible change, which really can't be done this way.
> If more error values are needed, they should be added at
> GLIBC_2.4 (likely not just on SPARC but on other arches as well).

My bad, that's what Uli did in the generic linux/Versions file.

This patch is better.

2005-12-27  David S. Miller  <davem@sunset.davemloft.net>

	* sysdeps/unix/sysv/linux/sparc/Versions: Add new errlist-compat
	entry for up to 134 errnos.

Index: sysdeps/unix/sysv/linux/sparc/Versions
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/unix/sysv/linux/sparc/Versions,v
retrieving revision 1.1
diff -p -r1.1 Versions
*** sysdeps/unix/sysv/linux/sparc/Versions	28 Aug 2002 23:56:02 -0000	1.1
--- sysdeps/unix/sysv/linux/sparc/Versions	27 Dec 2005 09:08:46 -0000
*************** libc {
*** 16,21 ****
--- 16,25 ----
      #errlist-compat	128
      _sys_errlist; sys_errlist; _sys_nerr; sys_nerr;
    }
+   GLIBC_2.4 {
+     #errlist-compat	134
+     _sys_errlist; sys_errlist; _sys_nerr; sys_nerr;
+   }
  }
  librt {
    GLIBC_2.3 {

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH]: Fix Sparc errlist-compat
  2005-12-27  9:10   ` David S. Miller
@ 2005-12-27 15:03     ` Ulrich Drepper
  2005-12-27 15:14       ` [PATCH]: Fix Alpha errlist-compat Jakub Jelinek
  0 siblings, 1 reply; 6+ messages in thread
From: Ulrich Drepper @ 2005-12-27 15:03 UTC (permalink / raw)
  To: David S. Miller; +Cc: libc-hacker

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

David S. Miller wrote:

> This patch is better.

Applied.

-- 
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 251 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH]: Fix Alpha errlist-compat
  2005-12-27 15:03     ` Ulrich Drepper
@ 2005-12-27 15:14       ` Jakub Jelinek
  2005-12-30  2:33         ` Richard Henderson
  0 siblings, 1 reply; 6+ messages in thread
From: Jakub Jelinek @ 2005-12-27 15:14 UTC (permalink / raw)
  To: Ulrich Drepper; +Cc: David S. Miller, libc-hacker

On Tue, Dec 27, 2005 at 07:03:05AM -0800, Ulrich Drepper wrote:
> David S. Miller wrote:
> 
> > This patch is better.
> 
> Applied.

Alpha needs similar changes (and MIPS probably too, but that's left
for MIPS maintainer):

2005-12-27  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/unix/sysv/linux/alpha/Versions: Add new errlist-compat
	entry for up to 138 errnos.

--- libc/sysdeps/unix/sysv/linux/alpha/Versions.jj	2004-05-07 14:32:48.000000000 +0200
+++ libc/sysdeps/unix/sysv/linux/alpha/Versions	2005-12-27 16:11:24.000000000 +0100
@@ -73,6 +73,10 @@ libc {
     #errlist-compat	132
     _sys_errlist; sys_errlist; _sys_nerr; sys_nerr;
   }
+  GLIBC_2.4 {
+    #errlist-compat	138
+    _sys_errlist; sys_errlist; _sys_nerr; sys_nerr;
+  }
   GLIBC_PRIVATE {
     __libc_alpha_cache_shape;
   }


	Jakub

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH]: Fix Alpha errlist-compat
  2005-12-27 15:14       ` [PATCH]: Fix Alpha errlist-compat Jakub Jelinek
@ 2005-12-30  2:33         ` Richard Henderson
  0 siblings, 0 replies; 6+ messages in thread
From: Richard Henderson @ 2005-12-30  2:33 UTC (permalink / raw)
  To: Jakub Jelinek; +Cc: Ulrich Drepper, David S. Miller, libc-hacker

On Tue, Dec 27, 2005 at 04:14:02PM +0100, Jakub Jelinek wrote:
> Alpha needs similar changes ...

Technically not, since Alpha never uses COPY relocs.  
But I'm ok with just making everything the same.


r~

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2005-12-30  2:33 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-12-27  3:51 [PATCH]: Fix Sparc errlist-compat David S. Miller
2005-12-27  8:53 ` Jakub Jelinek
2005-12-27  9:10   ` David S. Miller
2005-12-27 15:03     ` Ulrich Drepper
2005-12-27 15:14       ` [PATCH]: Fix Alpha errlist-compat Jakub Jelinek
2005-12-30  2:33         ` Richard Henderson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).