_GNU_SOURCE and sys/poll.h

_GNU_SOURCE and sys/poll.h

[Thorsten Kukuk]

[-- Attachment #1: Type: text/plain, Size: 594 bytes --]


Hi,

The following example:

#define _GNU_SOURCE
#include <sys/poll.h>

fails with the latest changes:

In file included from /usr/include/sys/poll.h:32,
                 from syspoll.c:2:
/usr/include/time.h:120: error: expected specifier-qualifier-list before __time_

Attached a fix for that.

  Thorsten

-- 
Thorsten Kukuk         http://www.suse.de/~kukuk/      kukuk@suse.de
SUSE LINUX Products GmbH       Maxfeldstr. 5       D-90409 Nuernberg
--------------------------------------------------------------------    
Key fingerprint = A368 676B 5E1B 3E46 CFCE  2D97 F8FD 4E23 56C6 FB4B

[-- Attachment #2: glibc-2.3.90-sys_poll.diff --]
[-- Type: text/plain, Size: 460 bytes --]

2006-01-21  Thorsten Kukuk  <kukuk@suse.de>

	* io/sys/poll.h: Define __need_time_t to get definition
	of time_t if __USE_GNU is defined.

--- io/sys/poll.h
+++ io/sys/poll.h	2006/01/21 08:49:35
@@ -27,7 +27,8 @@
 #ifdef __USE_GNU
 /* Get the __sigset_t definition.  */
 # include <bits/sigset.h>
-/* Get the timespec definition.  */
+/* Get the time_t and timespec definition.  */
+# define __need_time_t
 # define __need_timespec
 # include <time.h>
 #endif

Re: _GNU_SOURCE and sys/poll.h

[Ulrich Drepper]

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

Thorsten Kukuk wrote:
> Attached a fix for that.

No.  This should not be necessary.  <time.h> must be adjusted.

-- 
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 251 bytes --]

Re: _GNU_SOURCE and sys/poll.h

[Thorsten Kukuk]

On Sat, Jan 21, Ulrich Drepper wrote:

> Thorsten Kukuk wrote:
> > Attached a fix for that.
> 
> No.  This should not be necessary.  <time.h> must be adjusted.

This works for me, too:

2006-01-21  Thorsten Kukuk  <kukuk@suse.de>

	* time/time.h: declare time_t if __need_timespec is defined.

--- time/time.h
+++ time/time.h	2006/01/21 09:42:09
@@ -66,7 +66,8 @@
 #endif /* clock_t not defined and <time.h> or need clock_t.  */
 #undef	__need_clock_t
 
-#if !defined __time_t_defined && (defined _TIME_H || defined __need_time_t)
+#if !defined __time_t_defined && \
+   (defined _TIME_H || defined __need_time_t || defined __need_timespec)
 # define __time_t_defined	1
 
 # include <bits/types.h>


-- 
Thorsten Kukuk         http://www.suse.de/~kukuk/      kukuk@suse.de
SUSE LINUX Products GmbH       Maxfeldstr. 5       D-90409 Nuernberg
--------------------------------------------------------------------    
Key fingerprint = A368 676B 5E1B 3E46 CFCE  2D97 F8FD 4E23 56C6 FB4B

Re: _GNU_SOURCE and sys/poll.h

[Roland McGrath]

I've checked in what should be the right fix.